| Message ID | 1393356845-15287-1-git-send-email-bjorn@mork.no |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote: > These info messages are rather pointless without any means to identify > the source of the bogus packets. Logging the src and dst addresses > may help a bit. [] > diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c [] > @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto) > /* RFC 2460 section 8.1 says that we SHOULD log > this error. Well, it is reasonable. > */ > - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n"); > + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n", > + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr); Might be useful to mirror the ipv4 form and add port #'s too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Joe Perches <joe@perches.com> writes: > On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote: >> These info messages are rather pointless without any means to identify >> the source of the bogus packets. Logging the src and dst addresses >> may help a bit. > [] >> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c > [] >> @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto) >> /* RFC 2460 section 8.1 says that we SHOULD log >> this error. Well, it is reasonable. >> */ >> - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n"); >> + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n", >> + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr); > > Might be useful to mirror the ipv4 form and add port #'s too. Good point. New version coming up. Bjørn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c index 72d198b8e4d2..652716b06c2b 100644 --- a/net/ipv6/ip6_checksum.c +++ b/net/ipv6/ip6_checksum.c @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto) /* RFC 2460 section 8.1 says that we SHOULD log this error. Well, it is reasonable. */ - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n"); + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n", + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr); return 1; } if (skb->ip_summed == CHECKSUM_COMPLETE &&
These info messages are rather pointless without any means to identify the source of the bogus packets. Logging the src and dst addresses may help a bit. Signed-off-by: Bjørn Mork <bjorn@mork.no> --- net/ipv6/ip6_checksum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)