| Message ID | 1393332928-28879-1-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Superseded |
| Headers | show |
Gustavo, Gustavo Zacarias <gustavo@zacarias.com.ar> wrote on 02/25/2014 06:55:28 AM: > Fixes: > http://autobuild.buildroot.net/results/d46/ > d46f9097780bdde68ec15f693281ee0b04667f98/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/thrift/thrift.mk | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/package/thrift/thrift.mk b/package/thrift/thrift.mk > index d61cc3a..728a67a 100644 > --- a/package/thrift/thrift.mk > +++ b/package/thrift/thrift.mk > @@ -6,10 +6,11 @@ > > THRIFT_VERSION = 0.9.1 > THRIFT_SITE = http://www.us.apache.org/dist/thrift/$(THRIFT_VERSION) > -THRIFT_DEPENDENCIES = host-pkgconf host-thrift boost libevent openssl zlib > +THRIFT_DEPENDENCIES = host-bison host-pkgconf host-thrift boost libevent \ > + openssl zlib > THRIFT_INSTALL_STAGING = YES > HOST_THRIFT_DEPENDENCIES = host-boost host-libevent host-openssl host-pkgconf \ > - host-zlib > + host-zlib host-bison > THRIFT_CONF_OPT = --with-sysroot=$(STAGING_DIR) --with-tests=no \ > --with-boost=$(STAGING_DIR) > HOST_THRIFT_CONF_OPT = --with-sysroot=$(HOST_DIR) --with-tests=no I believe Thomas P submitted a patch today or last night that does something similar and was accepted. However it doesn't appear that he added a dependancy on the thrift package itself. http://patchwork.ozlabs.org/patch/323781/ Thanks, -Ryan
On 02/25/2014 10:19 AM, Ryan Barnett wrote: > I believe Thomas P submitted a patch today or last night that does > something similar and was accepted. However it doesn't appear that he > added a dependancy on the thrift package itself. > > http://patchwork.ozlabs.org/patch/323781/ > > Thanks, > -Ryan Right, mail backlog and no morning pull got me. I've already superseeded it in patchwork. Having it for thrift itself is mostly correctness at the moment since it depends on host-thrift, just if in the (unlikely) future of that changing. Regards.
diff --git a/package/thrift/thrift.mk b/package/thrift/thrift.mk index d61cc3a..728a67a 100644 --- a/package/thrift/thrift.mk +++ b/package/thrift/thrift.mk @@ -6,10 +6,11 @@ THRIFT_VERSION = 0.9.1 THRIFT_SITE = http://www.us.apache.org/dist/thrift/$(THRIFT_VERSION) -THRIFT_DEPENDENCIES = host-pkgconf host-thrift boost libevent openssl zlib +THRIFT_DEPENDENCIES = host-bison host-pkgconf host-thrift boost libevent \ + openssl zlib THRIFT_INSTALL_STAGING = YES HOST_THRIFT_DEPENDENCIES = host-boost host-libevent host-openssl host-pkgconf \ - host-zlib + host-zlib host-bison THRIFT_CONF_OPT = --with-sysroot=$(STAGING_DIR) --with-tests=no \ --with-boost=$(STAGING_DIR) HOST_THRIFT_CONF_OPT = --with-sysroot=$(HOST_DIR) --with-tests=no
Fixes: http://autobuild.buildroot.net/results/d46/d46f9097780bdde68ec15f693281ee0b04667f98/ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/thrift/thrift.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)