toolchain: control GNU_TARGET_NAME vendor part

>Right. I guess we can make this configurable. However, your patch has some issues:

> * It only creates the option BR2_TOOLCHAIN_BUILDROOT_VENDOR in the
>   internal toolchain backend. But GNU_TARGET_NAME is also used with
>   the external toolchain backend, which means in the external
>   toolchain case we would end up with a GNU_TARGET_NAME having an
>   empty vendor part of the tuple.

> * The new Config.in option lacks an help text, and the help text
>   should explain in detail how this should be used, and in which
>   situations. Also the title of the help text should be just
>   "custom toolchain vendor name".


Below is the revised patch.
Is it OK?
Is it the right way to bring up the corrections?
--
1.7.1

Thanks
Noam

Noam, All,

On 2014-02-23 15:41 +0000, Noam Camus spake thusly:
[--SNIP--]
> Below is the revised patch.
> Is it OK?
> Is it the right way to bring up the corrections?

Please just re-send the patch as you did the first time.
Be sure to annotate it as:
    [PATCH v2] blabla

You can do that with:
    git send-email --annotate [...]

[--SNIP--]
> diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
> index cd88889..216f308 100644
> --- a/toolchain/toolchain-buildroot/Config.in
> +++ b/toolchain/toolchain-buildroot/Config.in
> @@ -69,6 +69,18 @@ config BR2_TOOLCHAIN_BUILDROOT_LIBC
>  	default "glibc"  if BR2_TOOLCHAIN_BUILDROOT_EGLIBC
>  	default "glibc"  if BR2_TOOLCHAIN_BUILDROOT_GLIBC
>  
> +config BR2_TOOLCHAIN_BUILDROOT_VENDOR
> +	string "custom toolchain vendor name"
> +	default "buildroot"
> +	help
> +	  This option accepts name for vendor field in toolchain tuple.
> +	  The toolchain tuple full format is:
> +	  cpu-vendor-kernel-os
> +	  You may use it in case of custom toolchain.
> +	  e.g. if your gcc depend on this field to make decisions.
> +	  NOTE: "unknown" is not allowed since it may be confused
> +	  with host toolchain.

I think Thomas said on IRC that he will have a better wording for the
help text. Wait a little bit for his suggestion, before re-sending.

Thanks!

Regards,
Yann E. MORIN.

Dear Noam Camus,

On Sun, 23 Feb 2014 15:41:43 +0000, Noam Camus wrote:
> +config BR2_TOOLCHAIN_BUILDROOT_VENDOR
> +	string "custom toolchain vendor name"
> +	default "buildroot"
> +	help
> +	  This option accepts name for vendor field in toolchain tuple.
> +	  The toolchain tuple full format is:
> +	  cpu-vendor-kernel-os
> +	  You may use it in case of custom toolchain.
> +	  e.g. if your gcc depend on this field to make decisions.
> +	  NOTE: "unknown" is not allowed since it may be confused
> +	  with host toolchain.

A better wording IMO:

	This option allows to customize the "vendor" part of the
	toolchain tuple, where the toolchain tuple has the form
	<cpu>-<vendor>-<kernel>-<os>. The default value, "buildroot",
	is fine for most cases, except in very specific situations
	where gcc might make different decisions based on the vendor
	part of the tuple. The value "unknown" is not allowed as the
	cross-compiling toolchain might then be confused with the
	native toolchain when the target and host architecture are
	identical.

	If you're not sure, just leave the default "buildroot" value.

Thomas

>A better wording IMO:

>        This option allows to customize the "vendor" part of the
>         toolchain tuple, where the toolchain tuple has the form
>         <cpu>-<vendor>-<kernel>-<os>. The default value, "buildroot",
>         is fine for most cases, except in very specific situations
>         where gcc might make different decisions based on the vendor
>         part of the tuple. The value "unknown" is not allowed as the
>         cross-compiling toolchain might then be confused with the
>         native toolchain when the target and host architecture are
>         identical.

>        If you're not sure, just leave the default "buildroot" value.

Thanks 
It is indeed much better.
I will send PATCH V2