Patchwork [v2] xen-pciback: Use pci_enable_msix_exact() instead of pci_enable_msix()

login
register
mail settings
Submitter Alexander Gordeev
Date Feb. 21, 2014, 4:53 p.m.
Message ID <20140221165340.GG17353@dhcp-26-207.brq.redhat.com>
Download mbox | patch
Permalink /patch/322949/
State Not Applicable
Headers show

Comments

Alexander Gordeev - Feb. 21, 2014, 4:53 p.m.
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/xen/xen-pciback/pciback_ops.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Alexander Gordeev - Feb. 21, 2014, 5:02 p.m.
Hi Boris et al,

Based on recently accepted to the mainline pci_enable_msix_exact() function,
I am sending a updated version of the patch. Please, let me know if it does
not work for you and you need and incremental update from the previous version.

Thanks!
Boris Ostrovsky - Feb. 21, 2014, 6:33 p.m.
On 02/21/2014 11:53 AM, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range()  or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: linux-pci@vger.kernel.org

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

> ---
>   drivers/xen/xen-pciback/pciback_ops.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 64eb0cd..929dd46 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -213,8 +213,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
>   		entries[i].vector = op->msix_entries[i].vector;
>   	}
>   
> -	result = pci_enable_msix(dev, entries, op->value);
> -
> +	result = pci_enable_msix_exact(dev, entries, op->value);
>   	if (result == 0) {
>   		for (i = 0; i < op->value; i++) {
>   			op->msix_entries[i].entry = entries[i].entry;

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Gordeev - Feb. 21, 2014, 6:58 p.m.
On Fri, Feb 21, 2014 at 01:33:34PM -0500, Boris Ostrovsky wrote:
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Thank you, Boris!
Whom should I ask this patch for inclusion?
Boris Ostrovsky - Feb. 21, 2014, 7:09 p.m.
On 02/21/2014 01:58 PM, Alexander Gordeev wrote:
> On Fri, Feb 21, 2014 at 01:33:34PM -0500, Boris Ostrovsky wrote:
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Thank you, Boris!
> Whom should I ask this patch for inclusion?
>

This should go into the Xen tree. Konrad is usually the one putting 
together pull requests for Linus.

I don't think this needs to go in right away so presumably this will be 
queued for the next merge window (unless Konrad has other things for 
next RCs and decides to tack this onto other patches).


-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Konrad Rzeszutek Wilk - Feb. 21, 2014, 9:15 p.m.
On Fri, Feb 21, 2014 at 02:09:02PM -0500, Boris Ostrovsky wrote:
> On 02/21/2014 01:58 PM, Alexander Gordeev wrote:
> >On Fri, Feb 21, 2014 at 01:33:34PM -0500, Boris Ostrovsky wrote:
> >>Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> >Thank you, Boris!
> >Whom should I ask this patch for inclusion?
> >
> 
> This should go into the Xen tree. Konrad is usually the one putting
> together pull requests for Linus.
> 
> I don't think this needs to go in right away so presumably this will
> be queued for the next merge window (unless Konrad has other things
> for next RCs and decides to tack this onto other patches).

I was thinking for next one. Will have a branch ready on Monday.
> 
> 
> -boris
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Konrad Rzeszutek Wilk - Feb. 24, 2014, 7:18 p.m.
On Fri, Feb 21, 2014 at 05:53:40PM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range()  or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.

What is this based on? Thanks.

> 
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: linux-pci@vger.kernel.org
> ---
>  drivers/xen/xen-pciback/pciback_ops.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 64eb0cd..929dd46 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -213,8 +213,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
>  		entries[i].vector = op->msix_entries[i].vector;
>  	}
>  
> -	result = pci_enable_msix(dev, entries, op->value);
> -
> +	result = pci_enable_msix_exact(dev, entries, op->value);
>  	if (result == 0) {
>  		for (i = 0; i < op->value; i++) {
>  			op->msix_entries[i].entry = entries[i].entry;
> -- 
> 1.7.7.6
> 
> -- 
> Regards,
> Alexander Gordeev
> agordeev@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Gordeev - Feb. 25, 2014, 8:32 a.m.
On Mon, Feb 24, 2014 at 02:18:31PM -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Feb 21, 2014 at 05:53:40PM +0100, Alexander Gordeev wrote:
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updated to use the
> > new pci_enable_msi_range()  or pci_enable_msi_exact()
> > and pci_enable_msix_range() or pci_enable_msix_exact()
> > interfaces.
> 
> What is this based on? Thanks.

3.14-rc4

Patch

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 64eb0cd..929dd46 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -213,8 +213,7 @@  int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
 		entries[i].vector = op->msix_entries[i].vector;
 	}
 
-	result = pci_enable_msix(dev, entries, op->value);
-
+	result = pci_enable_msix_exact(dev, entries, op->value);
 	if (result == 0) {
 		for (i = 0; i < op->value; i++) {
 			op->msix_entries[i].entry = entries[i].entry;