Patchwork Re: Patch for review

login
register
mail settings
Submitter Rahul Jain
Date Feb. 21, 2014, 8:58 a.m.
Message ID <6D.8C.10103.C1517035@epcpsbgx1.samsung.com>
Download mbox | patch
Permalink /patch/322498/
State Accepted
Headers show

Comments

Rahul Jain - Feb. 21, 2014, 8:58 a.m.
hello Jouni,

 As requested, I am attaching patch with signed off.
==
rom 2d330d4b823a8aee9a509af4ea9a696baa8fad57 Mon Sep 17 00:00:00 2001
From: Rahul Jain <rahul.jain@samsung.com>

Date: Thu, 20 Feb 2014 16:34:09 +0530
Subject: [PATCH]  Fix for missing eloop_cancel_timeout  when p2p invitation
 is received


Signed-off-by: Rahul Jain <rahul.jain@samsung.com>

---
 src/p2p/p2p.c |    1 +
 1 file changed, 1 insertion(+)



The actual change itself looks reasonable, but I would need to receive a
patch with Signed-off-by line in the commit message to be able to apply
this. Could you please read the CONTRIBUTIONS file(*) and re-send this
with the Signed-off-by added as described in that file?

Please also note that HTML-only email is discouraged on this mailing
list and it would be highly preferred to get a plaintext version. As you
can see from the quoted version of the change above, this didn't look
very clear in my email reader... :)


(*) http://w1.fi/cgit/hostap/tree/CONTRIBUTIONS

-- 
Jouni Malinen                                            PGP id EFC895FA



Thanks
-Rahul Jain
Jouni Malinen - Feb. 21, 2014, 1:08 p.m.
On Fri, Feb 21, 2014 at 08:58:04AM +0000, Rahul Jain wrote:
>  As requested, I am attaching patch with signed off.
> Subject: [PATCH]  Fix for missing eloop_cancel_timeout  when p2p invitation
>  is received

Thanks, applied.

Patch

diff --git a/src/p2p/p2p.c b/src/p2p/p2p.c

index 2ecc547..1e9699e 100644

--- a/src/p2p/p2p.c

+++ b/src/p2p/p2p.c

@@ -2145,6 +2145,7 @@  p2p_probe_req_rx(struct p2p_data *p2p, const u8 *addr, const u8 *dst,

      == 0) {
   /* Received a Probe Request from Invite peer */
   p2p_dbg(p2p, "Found Invite peer - try to start Invite from timeout");
+  eloop_cancel_timeout(p2p_invite_start, p2p, NULL);

   eloop_register_timeout(0, 0, p2p_invite_start, p2p, NULL);
   return P2P_PREQ_PROCESSED;
  }
-- 

1.7.9.5
==

Thanks
-Rahul




------- Original Message -------

Sender : Jouni Malinen<j@w1.fi>
Date : Feb 21, 2014 14:12 (GMT+05:30)
Title : Re: Patch for review

On Fri, Feb 21, 2014 at 03:40:01AM +0000, Rahul Jain wrote:
> [PATCH]  Fix for missing eloop_cancel_timeout  when p2p invitation
 is received

> 
diff --git a/src/p2p/p2p.c b/src/p2p/p2p.c

index 2ecc547..1e9699e 100644

--- a/src/p2p/p2p.c

+++ b/src/p2p/p2p.c

@@ -2145,6 +2145,7 @@  p2p_probe_req_rx(struct p2p_data *p2p, const u8 *addr, const u8 *dst,

      == 0) {
   /* Received a Probe Request from Invite peer */
   p2p_dbg(p2p, "Found Invite peer - try to start Invite from timeout");
+  eloop_cancel_timeout(p2p_invite_start, p2p, NULL);

   eloop_register_timeout(0, 0, p2p_invite_start, p2p, NULL);
   return P2P_PREQ_PROCESSED;
  }