Patchwork tipc: fix test of bearer_priority range in tipc_register_media()

login
register
mail settings
Submitter roel kluin
Date Aug. 27, 2009, 12:03 p.m.
Message ID <4A967603.8070707@gmail.com>
Download mbox | patch
Permalink /patch/32248/
State Accepted
Delegated to: David Miller
Headers show

Comments

roel kluin - Aug. 27, 2009, 12:03 p.m.
For the bearer_priority to be less than TIPC_MIN_LINK_PRI and greater than
TIPC_MAX_LINK_PRI is logically impossible.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Aug. 29, 2009, 7:21 a.m.
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 27 Aug 2009 14:03:15 +0200

> For the bearer_priority to be less than TIPC_MIN_LINK_PRI and greater than
> TIPC_MAX_LINK_PRI is logically impossible.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index a7a3677..327011f 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -119,7 +119,7 @@  int  tipc_register_media(u32 media_type,
 		warn("Media <%s> rejected, no broadcast address\n", name);
 		goto exit;
 	}
-	if ((bearer_priority < TIPC_MIN_LINK_PRI) &&
+	if ((bearer_priority < TIPC_MIN_LINK_PRI) ||
 	    (bearer_priority > TIPC_MAX_LINK_PRI)) {
 		warn("Media <%s> rejected, illegal priority (%u)\n", name,
 		     bearer_priority);