Patchwork lmb: Remove __init from lmb_end_of_DRAM()

login
register
mail settings
Submitter Benjamin Herrenschmidt
Date Aug. 27, 2009, 7:20 a.m.
Message ID <1251357630.20467.42.camel@pasglop>
Download mbox | patch
Permalink /patch/32224/
State Accepted
Headers show

Comments

Benjamin Herrenschmidt - Aug. 27, 2009, 7:20 a.m.
We call lmb_end_of_DRAM() to test whether a DMA mask
is ok on a machine without IOMMU, but this function is
marked as __init.

I don't think there's a clean way to get the top of RAM
max_pfn doesn't appear to include highmem or I missed
(or we have a bug :-) so for now, let's just avoid having
a broken 2.6.31 by making this function non-__init and we
can revisit later.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

David, you use lmb too, any objection there ?

Patch

diff --git a/lib/lmb.c b/lib/lmb.c
index e4a6482..0343c05 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -429,7 +429,7 @@  u64 __init lmb_phys_mem_size(void)
 	return lmb.memory.size;
 }
 
-u64 __init lmb_end_of_DRAM(void)
+u64 lmb_end_of_DRAM(void)
 {
 	int idx = lmb.memory.cnt - 1;