diff mbox

Makefile: fix target-finalize rule

Message ID 1392906378-30112-1-git-send-email-fabio.porcedda@gmail.com
State Accepted
Commit d4c0c642de85489a536e89d252ef6e19ecbbd6a4
Headers show

Commit Message

Fabio Porcedda Feb. 20, 2014, 2:26 p.m. UTC
Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5
(Makefile: add support for top-level parallel make).

That commit put a new rule inside the target-finalize rule so it was
erroneously splitted in two parts.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas De Schampheleire Feb. 20, 2014, 2:40 p.m. UTC | #1
On Thu, Feb 20, 2014 at 3:26 PM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5
> (Makefile: add support for top-level parallel make).
>
> That commit put a new rule inside the target-finalize rule so it was
> erroneously splitted in two parts.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>

Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Peter Korsgaard Feb. 20, 2014, 6:21 p.m. UTC | #2
>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Fix a bug introduced by the commit a24877586a566e052897e50e6a0c2f53cfb029f5
 > (Makefile: add support for top-level parallel make).

 > That commit put a new rule inside the target-finalize rule so it was
 > erroneously splitted in two parts.

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
 > Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
 > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>

Committed to next, thanks.
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 20aabd6..de568e3 100644
--- a/Makefile
+++ b/Makefile
@@ -507,6 +507,8 @@  endif
 STRIP_FIND_CMD += -type f \( -perm /111 -o -name '*.so*' \)
 STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print
 
+$(TARGETS_ROOTFS): target-finalize
+
 target-finalize: $(TARGETS)
 	rm -rf $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/share/aclocal \
 		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
@@ -534,8 +536,6 @@  endif
 		find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \
 		xargs -r $(KSTRIPCMD); fi
 
-$(TARGETS_ROOTFS): target-finalize
-
 # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads
 # besides the one in which crash occurred; or SIGTRAP kills my program when
 # I set a breakpoint"