mbox

[PULL] Chardev fix

Message ID 20140220100038.GA7585@grmbl.mre
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git char-fixes

Message

Amit Shah Feb. 20, 2014, 10 a.m. UTC 
Hi,

This fix by Gal Hammer has been on list for quite a while, please pull.


The following changes since commit
46eef33b89e936ca793e13c4aeea1414e97e8dbb:

  Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git  char-fixes

for you to fetch changes up to
5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:

  char: restore read callback on a reattached (hotplug) chardev
  (2014-02-20 15:17:32 +0530)

----------------------------------------------------------------
Gal Hammer (1):
      char: restore read callback on a reattached (hotplug) chardev

 qemu-char.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)


		Amit

Comments

Peter Maydell Feb. 21, 2014, 2:55 p.m. UTC | #1 
On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> This fix by Gal Hammer has been on list for quite a while, please pull.
>
>
> The following changes since commit
> 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
>
>   Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git  char-fixes
>
> for you to fetch changes up to
> 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
>
>   char: restore read callback on a reattached (hotplug) chardev
>   (2014-02-20 15:17:32 +0530)

Sorry, but this fails 'make check':

GTESTER check-qtest-aarch64
qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
Broken pipe

(not aarch64-specific either; if you let make continue past
errors it asserts on just about every other softmmu test too).

thanks
-- PMM
Amit Shah Feb. 24, 2014, 5:52 a.m. UTC | #2 
On (Fri) 21 Feb 2014 [14:55:48], Peter Maydell wrote:
> On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> > This fix by Gal Hammer has been on list for quite a while, please pull.
> >
> >
> > The following changes since commit
> > 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> >
> >   Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git  char-fixes
> >
> > for you to fetch changes up to
> > 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
> >
> >   char: restore read callback on a reattached (hotplug) chardev
> >   (2014-02-20 15:17:32 +0530)
> 
> Sorry, but this fails 'make check':
> 
> GTESTER check-qtest-aarch64
> qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
> tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
> Broken pipe
> 
> (not aarch64-specific either; if you let make continue past
> errors it asserts on just about every other softmmu test too).

Sorry about that!

Gal, can you take a look?

		Amit