Patchwork [26/29] Introduce QInt unit-tests

login
register
mail settings
Submitter Luiz Capitulino
Date Aug. 26, 2009, 5:05 p.m.
Message ID <1251306352-31316-27-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/32205/
State Superseded
Headers show

Comments

Luiz Capitulino - Aug. 26, 2009, 5:05 p.m.
This suite contains tests to assure that QInt API works as expected.

To execute it you should have check installed and build QEMU with
check support enabled (--enable-check) and then run:

$ ./check-qint

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 Makefile     |    1 +
 check-qint.c |  110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 configure    |    2 +-
 3 files changed, 112 insertions(+), 1 deletions(-)
 create mode 100644 check-qint.c
Luiz Capitulino - Aug. 28, 2009, 6:26 p.m.
On Wed, 26 Aug 2009 23:55:49 +0200
Juan Quintela <quintela@trasno.org> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > This suite contains tests to assure that QInt API works as expected.
> >
> > To execute it you should have check installed and build QEMU with
> > check support enabled (--enable-check) and then run:
> >
> > $ ./check-qint
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  Makefile     |    1 +
> >  check-qint.c |  110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  configure    |    2 +-
> >  3 files changed, 112 insertions(+), 1 deletions(-)
> >  create mode 100644 check-qint.c
> >
> > diff --git a/Makefile b/Makefile
> > index efeb6ba..16dbc16 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -182,6 +182,7 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
> >  
> >  ifdef CONFIG_CHECK
> >  LIBS += $(CHECK_LIBS)
> > +check-qint: check-qint.o qint.o qemu-malloc.o
> 
> Don't put it under ifdef
> put the dependency alwasy there.
> 
> and I think that:
> 
> check-%: check-%.o %.o quemu-malloc.o
> 
> should work for all your cases, do you care to test?

 Didn't work on first try.

Patch

diff --git a/Makefile b/Makefile
index efeb6ba..16dbc16 100644
--- a/Makefile
+++ b/Makefile
@@ -182,6 +182,7 @@  qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
 
 ifdef CONFIG_CHECK
 LIBS += $(CHECK_LIBS)
+check-qint: check-qint.o qint.o qemu-malloc.o
 endif
 
 clean:
diff --git a/check-qint.c b/check-qint.c
new file mode 100644
index 0000000..ae5d22f
--- /dev/null
+++ b/check-qint.c
@@ -0,0 +1,110 @@ 
+/*
+ * QInt unit-tests.
+ *
+ * Copyright (C) 2009 Red Hat Inc.
+ *
+ * Authors:
+ *  Luiz Capitulino <lcapitulino@redhat.com>
+ */
+#include <check.h>
+
+#include "qint.h"
+#include "qemu-common.h"
+
+/*
+ * Public Interface test-cases
+ *
+ * (with some violations to access 'private' data)
+ */
+
+START_TEST(qint_from_int_test)
+{
+    QInt *qi;
+    const int value = -42;
+
+    qi = qint_from_int(value);
+    fail_unless(qi != NULL);
+    fail_unless(qi->value == value);
+    fail_unless(qi->base.refcnt == 1);
+    fail_unless(qobject_type(QOBJECT(qi)) == QTYPE_QINT);
+
+    // destroy doesn't exit yet
+    qemu_free(qi);
+}
+END_TEST
+
+START_TEST(qint_destroy_test)
+{
+    QInt *qi = qint_from_int(0);
+    QDECREF(qi);
+}
+END_TEST
+
+START_TEST(qint_from_int64_test)
+{
+    QInt *qi;
+    const int64_t value = 0xffffffffffffffff;
+
+    qi = qint_from_int(value);
+    fail_unless(qi->value == value);
+
+    QDECREF(qi);
+}
+END_TEST
+
+START_TEST(qint_get_int_test)
+{
+    QInt *qi;
+    const int value = 123456;
+
+    qi = qint_from_int(value);
+    fail_unless(qint_get_int(qi) == value);
+
+    QDECREF(qi);
+}
+END_TEST
+
+START_TEST(qobject_to_qint_test)
+{
+    QInt *qi;
+
+    qi = qint_from_int(0);
+    fail_unless(qobject_to_qint(QOBJECT(qi)) == qi);
+
+    QDECREF(qi);
+}
+END_TEST
+
+static Suite *qint_suite(void)
+{
+    Suite *s;
+    TCase *qint_public_tcase;
+
+    s = suite_create("QInt test-suite");
+
+    qint_public_tcase = tcase_create("Public Interface");
+    suite_add_tcase(s, qint_public_tcase);
+    tcase_add_test(qint_public_tcase, qint_from_int_test);
+    tcase_add_test(qint_public_tcase, qint_destroy_test);
+    tcase_add_test(qint_public_tcase, qint_from_int64_test);
+    tcase_add_test(qint_public_tcase, qint_get_int_test);
+    tcase_add_test(qint_public_tcase, qobject_to_qint_test);
+
+    return s;
+}
+
+int main(void)
+{
+	int nf;
+	Suite *s;
+	SRunner *sr;
+
+	s = qint_suite();
+	sr = srunner_create(s);
+
+	srunner_run_all(sr, CK_NORMAL);
+	nf = srunner_ntests_failed(sr);
+	srunner_free(sr);
+
+	return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
+}
diff --git a/configure b/configure
index 18cb586..fef7074 100755
--- a/configure
+++ b/configure
@@ -1753,7 +1753,7 @@  if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
   if [ "$linux" = "yes" ] ; then
       tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools"
     if [ "$check" = "yes" ]; then
-      tools="$tools"
+      tools="check-qint $tools"
     fi
   fi
 fi