Patchwork UBUNTU: [config] Set IPMI suppoort default to "y"

login
register
mail settings
Submitter Colin King
Date Feb. 19, 2014, 3:06 p.m.
Message ID <1392822402-25108-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/321940/
State New
Headers show

Comments

Colin King - Feb. 19, 2014, 3:06 p.m.
From: Colin Ian King <colin.king@canonical.com>

A recent linux-pm commit (bleeding-edge branch, commit
73fe8b8784bbc7c792144c0a1711a5c9ff219288) by Matthet Garrett
has defaulted IPMI support to "y". The rational is to avoid
early access failures during the kernel initialisation. The
commit states:

   "The ACPI IPMI driver implements IPMI operation region
    support for the ACPI core. Systems that declare ACPI
    operation regions may reference them at any time,
    including during kernel initialisation. These accesses
    will fail unless the ACPI IPMI driver is present, and
    undesirable system behaviour may result. Set the default
    to Y in order to encourage distributions and users to
    configure kernels to avoid awkward surprises."

Apparently this affects the Dell R720 and HP DL385 and maybe
some Ciscos too.   So it seems pertinent to set our default
configs appropriately.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 debian.master/config/config.common.ubuntu | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Tim Gardner - Feb. 19, 2014, 6:53 p.m.

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index e84b575..8ce756f 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -54,7 +54,7 @@  CONFIG_ACPI_HED=y
 CONFIG_ACPI_HOTPLUG_CPU=y
 CONFIG_ACPI_HOTPLUG_MEMORY=y
 # CONFIG_ACPI_INITRD_TABLE_OVERRIDE is not set
-CONFIG_ACPI_IPMI=m
+CONFIG_ACPI_IPMI=y
 CONFIG_ACPI_NUMA=y
 CONFIG_ACPI_PCI_SLOT=y
 CONFIG_ACPI_PROCESSOR=y
@@ -2993,10 +2993,10 @@  CONFIG_IPDDP=m
 CONFIG_IPDDP_ENCAP=y
 # CONFIG_IPIC is not set
 CONFIG_IPMI_DEVICE_INTERFACE=m
-CONFIG_IPMI_HANDLER=m
+CONFIG_IPMI_HANDLER=y
 # CONFIG_IPMI_PANIC_EVENT is not set
 CONFIG_IPMI_POWEROFF=m
-CONFIG_IPMI_SI=m
+CONFIG_IPMI_SI=y
 CONFIG_IPMI_WATCHDOG=m
 CONFIG_IPPP_FILTER=y
 CONFIG_IPV6=y