diff mbox

[v2,1/5] mfd: add bcm590xx pmu DT binding

Message ID 1392765432-9111-2-git-send-email-mporter@linaro.org
State Superseded, archived
Headers show

Commit Message

Matt Porter Feb. 18, 2014, 11:17 p.m. UTC 
Add a DT binding for the BCM590xx PMUs. The binding inherits from
the generic regulator bindings.

Signed-off-by: Matt Porter <mporter@linaro.org>
Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
---
 Documentation/devicetree/bindings/mfd/bcm590xx.txt | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/bcm590xx.txt

Comments

Mark Brown Feb. 19, 2014, 4:47 a.m. UTC | #1 
On Tue, Feb 18, 2014 at 06:17:08PM -0500, Matt Porter wrote:

> +
> +				rfldo_reg: regulator@0 {
> +					reg = <0>;

What do these reg values mean, they don't seem to be documented in the
binding?
Matt Porter March 11, 2014, 3:49 p.m. UTC | #2 
On Wed, Feb 19, 2014 at 01:47:26PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:08PM -0500, Matt Porter wrote:
> 
> > +
> > +				rfldo_reg: regulator@0 {
> > +					reg = <0>;
> 
> What do these reg values mean, they don't seem to be documented in the
> binding?

Dropped this and the deprecated regulator-compatible property in v3 in
favor of using node name matching.

-Matt
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/bcm590xx.txt b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
new file mode 100644
index 0000000..a4a8039
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
@@ -0,0 +1,49 @@ 
+-------------------------------
+BCM590xx Power Management Units
+-------------------------------
+
+Required properties:
+- compatible: "brcm,bcm59056"
+- reg: I2C slave address
+- interrupts: interrupt for the PMU. Generic interrupt client node bindings
+  are described in interrupt-controller/interrupts.txt
+
+-----------------------
+BCM590xx PMU Regulators
+-----------------------
+
+Required properties:
+- compatible: "brcm,bcm59056-regs"
+
+Optional properties:
+- regulators: This is the list of child nodes that specify the regulator
+  initialization data for defined regulators.  Generic regulator bindings
+  are described in regulator/regulator.txt.
+
+  The valid regulator-compatible values for BCM59056 are:
+  	rfldo, camldo1, camldo2, simldo1, simlso2, sdldo, sdxldo,
+	mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
+	csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr
+
+Example:
+	pmu: bcm59056@8 {
+		compatible = "brcm,bcm59056";
+		reg = <0x08>;
+		interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
+		regs {
+			compatible = "brcm,bcm59056-regs";
+			regulators {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				rfldo_reg: regulator@0 {
+					reg = <0>;
+					regulator-compatible = "rfldo";
+					regulator-min-microvolt = <1200000>;
+					regulator-max-microvolt = <3300000>;
+				};
+
+				...
+			};
+		};
+	};