Message ID | 53038CBB.4080808@redhat.com |
---|---|
State | New |
Headers | show |
On Tue, Feb 18, 2014 at 5:39 PM, nick clifton <nickc@redhat.com> wrote: > Hi Richard, > > >> Instead of modifying testcases I'd be less nervous if you'd make them >> require 32bit. Otherwise you should reproduce the original issues with the >> modified testcases. > > > OK, I can do that. How about this patch. > > > OK to apply ? Ok. Thanks, Richard. > Cheers > Nick > > gcc/testsuite/ChangeLog > 2014-02-18 Nick Clifton <nickc@redhat.com> > > * gcc.dg/graphite/pr46966.c: Only run on 32-bit+ targets. > * gcc.dg/pr23623.c: Likewise. > * gcc.dg/pr48784-1.c: Likewise. > * gcc.dg/pr48784-2.c: Likewise. > * gcc.dg/pr56997-2.c: Likewise. > * gcc.dg/sms-6.c: Likewise. > * gcc.dg/torture/pr60183.c: Likewise. > * gcc.dg/torture/vec-cvt-1.c: Likewise. > * gcc.c-torture/execute/20061220-1.x: New. > * gcc.c-torture/execute/pr43220.x: New. > * gcc.c-torture/execute/pr51581-1.x: New. > * gcc.c-torture/execute/pr51581-2.x: New. > * gcc.c-torture/execute/pr58570.x: New. > * gcc.c-torture/unsorted/DFcmp.x: New. > * gcc.c-torture/unsorted/SFset.x: New. >
Index: gcc/testsuite/gcc.dg/graphite/pr46966.c =================================================================== --- gcc/testsuite/gcc.dg/graphite/pr46966.c (revision 207836) +++ gcc/testsuite/gcc.dg/graphite/pr46966.c (working copy) @@ -1,5 +1,7 @@ /* PR tree-optimization/46966 */ /* { dg-do compile } */ +/* This test is too big for small targets. */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-O -floop-interchange -ffast-math -fno-tree-copy-prop -fno-tree-loop-im" } */ int a[1000][1000]; Index: gcc/testsuite/gcc.dg/pr23623.c =================================================================== --- gcc/testsuite/gcc.dg/pr23623.c (revision 207836) +++ gcc/testsuite/gcc.dg/pr23623.c (working copy) @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-fstrict-volatile-bitfields -fdump-rtl-final" } */ /* With -fstrict-volatile-bitfields, the volatile accesses to bf2.b Index: gcc/testsuite/gcc.dg/pr48784-1.c =================================================================== --- gcc/testsuite/gcc.dg/pr48784-1.c (revision 207836) +++ gcc/testsuite/gcc.dg/pr48784-1.c (working copy) @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-fstrict-volatile-bitfields" } */ extern void abort (void); Index: gcc/testsuite/gcc.dg/pr48784-2.c =================================================================== --- gcc/testsuite/gcc.dg/pr48784-2.c (revision 207836) +++ gcc/testsuite/gcc.dg/pr48784-2.c (working copy) @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-fno-strict-volatile-bitfields" } */ extern void abort (void); Index: gcc/testsuite/gcc.dg/pr56997-2.c =================================================================== --- gcc/testsuite/gcc.dg/pr56997-2.c (revision 207836) +++ gcc/testsuite/gcc.dg/pr56997-2.c (working copy) @@ -1,5 +1,6 @@ /* Test volatile access to unaligned field. */ /* { dg-do run } */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-fstrict-volatile-bitfields" } */ extern void abort (void); Index: gcc/testsuite/gcc.dg/sms-6.c =================================================================== --- gcc/testsuite/gcc.dg/sms-6.c (revision 207836) +++ gcc/testsuite/gcc.dg/sms-6.c (working copy) @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target size32plus } */ /* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1" } */ /* { dg-options "-O2 -fmodulo-sched -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves" { target powerpc*-*-* } } */ Index: gcc/testsuite/gcc.dg/torture/pr60183.c =================================================================== --- gcc/testsuite/gcc.dg/torture/pr60183.c (revision 207836) +++ gcc/testsuite/gcc.dg/torture/pr60183.c (working copy) @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target size32plus } */ /* Large so an out-of-bound read will crash. */ unsigned char c[0x30001] = { 1 }; Index: gcc/testsuite/gcc.dg/torture/vec-cvt-1.c =================================================================== --- gcc/testsuite/gcc.dg/torture/vec-cvt-1.c (revision 207836) +++ gcc/testsuite/gcc.dg/torture/vec-cvt-1.c (working copy) @@ -1,4 +1,6 @@ /* { dg-do run } */ +/* This test is too big for small targets. */ +/* { dg-require-effective-target size32plus } */ #include <stdlib.h> *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/execute/20061220-1.x 2014-02-12 17:20:52.601890142 +0000 *************** *** 0 **** --- 1,6 ---- + # asm statements for the RL78 do not work as expected + if { [istarget "rl78-*-*"] } { + return 1; + } + + return 0 *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/execute/pr43220.x 2014-02-18 13:07:38.953426402 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int16] } { + return 1 + } + + return 0; *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/execute/pr51581-1.x 2014-02-12 17:27:28.208877630 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int32plus] } { + return 0 + } + + return 1; *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/execute/pr51581-2.x 2014-02-12 17:28:01.607876574 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int32plus] } { + return 0 + } + + return 1; *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/execute/pr58570.x 2014-02-18 13:08:06.783427174 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int16] } { + return 1 + } + + return 0; *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/unsorted/DFcmp.x 2014-02-18 13:08:23.102427626 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int16] } { + return 1 + } + + return 0; *** /dev/null 2014-02-18 08:00:55.971916261 +0000 --- gcc/testsuite/gcc.c-torture/unsorted/SFset.x 2014-02-18 13:08:57.315428575 +0000 *************** *** 0 **** --- 1,7 ---- + load_lib target-supports.exp + + if { [check_effective_target_int16] } { + return 1 + } + + return 0;
Hi Richard, > Instead of modifying testcases I'd be less nervous if you'd make them require 32bit. Otherwise you should reproduce the original issues with the modified testcases. OK, I can do that. How about this patch. OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2014-02-18 Nick Clifton <nickc@redhat.com> * gcc.dg/graphite/pr46966.c: Only run on 32-bit+ targets. * gcc.dg/pr23623.c: Likewise. * gcc.dg/pr48784-1.c: Likewise. * gcc.dg/pr48784-2.c: Likewise. * gcc.dg/pr56997-2.c: Likewise. * gcc.dg/sms-6.c: Likewise. * gcc.dg/torture/pr60183.c: Likewise. * gcc.dg/torture/vec-cvt-1.c: Likewise. * gcc.c-torture/execute/20061220-1.x: New. * gcc.c-torture/execute/pr43220.x: New. * gcc.c-torture/execute/pr51581-1.x: New. * gcc.c-torture/execute/pr51581-2.x: New. * gcc.c-torture/execute/pr58570.x: New. * gcc.c-torture/unsorted/DFcmp.x: New. * gcc.c-torture/unsorted/SFset.x: New.