From patchwork Wed Aug 26 12:01:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: frank.blaschka@de.ibm.com X-Patchwork-Id: 32133 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E468DB70B3 for ; Wed, 26 Aug 2009 22:01:52 +1000 (EST) Received: by ozlabs.org (Postfix) id D5629DDD0C; Wed, 26 Aug 2009 22:01:52 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 5F5FEDDD0B for ; Wed, 26 Aug 2009 22:01:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbZHZMBk (ORCPT ); Wed, 26 Aug 2009 08:01:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756586AbZHZMBh (ORCPT ); Wed, 26 Aug 2009 08:01:37 -0400 Received: from mtagate2.de.ibm.com ([195.212.17.162]:36829 "EHLO mtagate2.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754576AbZHZMBf (ORCPT ); Wed, 26 Aug 2009 08:01:35 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id n7QC1bhn029141; Wed, 26 Aug 2009 12:01:37 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7QC1bkO1020040; Wed, 26 Aug 2009 14:01:37 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7QC1aRZ032623; Wed, 26 Aug 2009 14:01:37 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n7QC1aRL032618; Wed, 26 Aug 2009 14:01:36 +0200 Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 24631) id 9B07F1224229; Wed, 26 Aug 2009 14:01:36 +0200 (CEST) Message-Id: <20090826120136.512410000@de.ibm.com> User-Agent: quilt/0.47-1 Date: Wed, 26 Aug 2009 14:01:10 +0200 From: frank.blaschka@de.ibm.com To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, Ursula Braun Subject: [patch 5/5] [PATCH] qeth: display "undefined" value of sysfs-attribute "layer2" References: <20090826120105.727838000@de.ibm.com> Content-Disposition: inline; filename=612-qeth-layer2-attribute.diff Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ursula Braun If nothing has been written into the qeth sysfs-attribute layer2, its value is "-1" meaning "not yet defined". But the value is displayed as "1" meaning "layer2 selected". The patch changes the reading of this "-1"-value to "-1" to make clear the layer2-attribute has not yet been defined. Signed-off-by: Ursula Braun --- drivers/s390/net/qeth_core_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: git_net-next/drivers/s390/net/qeth_core_sys.c =================================================================== --- git_net-next.orig/drivers/s390/net/qeth_core_sys.c +++ git_net-next/drivers/s390/net/qeth_core_sys.c @@ -364,7 +364,7 @@ static ssize_t qeth_dev_layer2_show(stru if (!card) return -EINVAL; - return sprintf(buf, "%i\n", card->options.layer2 ? 1:0); + return sprintf(buf, "%i\n", card->options.layer2); } static ssize_t qeth_dev_layer2_store(struct device *dev,