| Message ID | 1392680233-24585-3-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Maxime Hadjinlian, On Tue, 18 Feb 2014 00:37:11 +0100, Maxime Hadjinlian wrote: > diff --git a/package/sdl_image/sdl_image.mk b/package/sdl_image/sdl_image.mk > index ba9751d..05b9a1f 100644 > --- a/package/sdl_image/sdl_image.mk > +++ b/package/sdl_image/sdl_image.mk > @@ -38,4 +38,15 @@ SDL_IMAGE_DEPENDENCIES = sdl \ > $(if $(BR2_PACKAGE_SDL_IMAGE_TIFF),tiff) \ > $(if $(BR2_PACKAGE_SDL_IMAGE_WEBP),webp) > > +HOST_SDL_IMAGE_CONF_OPT = --with-sdl-prefix=$(HOST_DIR)/usr \ > + --with-sdl-exec-prefix=$(HOST_DIR)/usr \ > + --disable-sdltest \ > + --disable-static \ > + --disable-jpg-shared \ > + --disable-png-shared \ > + --disable-tif-shared \ This is nitpicking, but we normally intend this with one tab, do not have a backslash on the last line, and also intend the first line. So, something like: HOST_SDL_IMAGE_CONF_OPT = \ --with-sdl-prefix=... \ --foo \ --bar \ --baz Thanks, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Dear Maxime Hadjinlian, > On Tue, 18 Feb 2014 00:37:11 +0100, Maxime Hadjinlian wrote: >> diff --git a/package/sdl_image/sdl_image.mk b/package/sdl_image/sdl_image.mk >> index ba9751d..05b9a1f 100644 >> --- a/package/sdl_image/sdl_image.mk >> +++ b/package/sdl_image/sdl_image.mk >> @@ -38,4 +38,15 @@ SDL_IMAGE_DEPENDENCIES = sdl \ >> $(if $(BR2_PACKAGE_SDL_IMAGE_TIFF),tiff) \ >> $(if $(BR2_PACKAGE_SDL_IMAGE_WEBP),webp) >> >> +HOST_SDL_IMAGE_CONF_OPT = --with-sdl-prefix=$(HOST_DIR)/usr \ >> + --with-sdl-exec-prefix=$(HOST_DIR)/usr \ >> + --disable-sdltest \ >> + --disable-static \ >> + --disable-jpg-shared \ >> + --disable-png-shared \ >> + --disable-tif-shared \ > This is nitpicking, but we normally intend this with one tab, do not > have a backslash on the last line, and also intend the first line. So, > something like: > HOST_SDL_IMAGE_CONF_OPT = \ > --with-sdl-prefix=... \ > --foo \ > --bar \ > --baz True, but this atleast matches what is done just above for the target version. With that being said, a followup patch to cleanup both would be nice.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > Host version is needed to build xbmc > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Committed to next, thanks.
diff --git a/package/sdl_image/sdl_image.mk b/package/sdl_image/sdl_image.mk index ba9751d..05b9a1f 100644 --- a/package/sdl_image/sdl_image.mk +++ b/package/sdl_image/sdl_image.mk @@ -38,4 +38,15 @@ SDL_IMAGE_DEPENDENCIES = sdl \ $(if $(BR2_PACKAGE_SDL_IMAGE_TIFF),tiff) \ $(if $(BR2_PACKAGE_SDL_IMAGE_WEBP),webp) +HOST_SDL_IMAGE_CONF_OPT = --with-sdl-prefix=$(HOST_DIR)/usr \ + --with-sdl-exec-prefix=$(HOST_DIR)/usr \ + --disable-sdltest \ + --disable-static \ + --disable-jpg-shared \ + --disable-png-shared \ + --disable-tif-shared \ + +HOST_SDL_IMAGE_DEPENDENCIES = host-libjpeg host-libpng host-sdl + $(eval $(autotools-package)) +$(eval $(host-autotools-package))