diff mbox

[1/1] Fix hostapd and wpa_supplicant build with binutils >= 2.24.x

Message ID 1392663767-30469-1-git-send-email-roger.zanoni@openbossa.org
State Accepted
Headers show

Commit Message

Roger Zanoni Feb. 17, 2014, 7:02 p.m. UTC
Using binutils >= 2.24.x and setting
CONFIG_WPA_TRACE/CONFIG_WPA_TRACE_BDF causes both builds to fail with
"#error config.h must be included before this header" message.

Since version 2.24.x, the bfd header checks for PACKAGE and
PACKAGE_VERSION macros.

As suggested in http://sourceware.org/bugzilla/show_bug.cgi?id=14243
projects that use bfd and don't use autotools should define a PACKAGE
macro.

Signed-off-by: Roger Zanoni <roger.zanoni@openbossa.org>
---
 hostapd/Makefile        | 2 +-
 wpa_supplicant/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jouni Malinen Feb. 19, 2014, 1:21 p.m. UTC | #1
On Mon, Feb 17, 2014 at 03:02:47PM -0400, Roger Zanoni wrote:
> Using binutils >= 2.24.x and setting
> CONFIG_WPA_TRACE/CONFIG_WPA_TRACE_BDF causes both builds to fail with
> "#error config.h must be included before this header" message.
> 
> Since version 2.24.x, the bfd header checks for PACKAGE and
> PACKAGE_VERSION macros.
> 
> As suggested in http://sourceware.org/bugzilla/show_bug.cgi?id=14243
> projects that use bfd and don't use autotools should define a PACKAGE
> macro.

Thanks, applied.
diff mbox

Patch

diff --git a/hostapd/Makefile b/hostapd/Makefile
index ef093e5..d7ff91e 100644
--- a/hostapd/Makefile
+++ b/hostapd/Makefile
@@ -77,7 +77,7 @@  HOBJS += ../src/utils/trace.o
 LDFLAGS += -rdynamic
 CFLAGS += -funwind-tables
 ifdef CONFIG_WPA_TRACE_BFD
-CFLAGS += -DWPA_TRACE_BFD
+CFLAGS += -DPACKAGE="hostapd" -DWPA_TRACE_BFD
 LIBS += -lbfd
 LIBS_c += -lbfd
 LIBS_h += -lbfd
diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
index d1e11a3..496f6fb 100644
--- a/wpa_supplicant/Makefile
+++ b/wpa_supplicant/Makefile
@@ -106,7 +106,7 @@  OBJS_priv += ../src/utils/trace.o
 LDFLAGS += -rdynamic
 CFLAGS += -funwind-tables
 ifdef CONFIG_WPA_TRACE_BFD
-CFLAGS += -DWPA_TRACE_BFD
+CFLAGS += -DPACKAGE="wpa_supplicant" -DWPA_TRACE_BFD
 LIBS += -lbfd
 LIBS_p += -lbfd
 LIBS_c += -lbfd