| Message ID | 20140217113125.GA4136@atmel.com |
|---|---|
| State | New |
| Headers | show |
Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> writes: > The newly added gcc.dg/torture/pr60183.c test fails for the AVR target > with an "array size too large" error. This patch marks the test as > unsupported for AVR, following the example of other such tests in the > testsuite. [...] > diff --git gcc/testsuite/gcc.dg/torture/pr60183.c gcc/testsuite/gcc.dg/torture/pr60183.c > index d37b4b8..8e519dc 100644 > --- gcc/testsuite/gcc.dg/torture/pr60183.c > +++ gcc/testsuite/gcc.dg/torture/pr60183.c > @@ -1,4 +1,5 @@ > /* { dg-do run } */ > +/* { dg-skip-if "Size of array too big" { "avr-*-*" } { "*" } { "" } } */ Please omit the last two default args to dg-skip-if. Besides, I don't like explicitly listing targets here. We should have an effective-target keyword for this issue. Rainer
2014-02-17 20:00 GMT+08:00 Rainer Orth <ro@cebitec.uni-bielefeld.de>: > Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> writes: > >> The newly added gcc.dg/torture/pr60183.c test fails for the AVR target >> with an "array size too large" error. This patch marks the test as >> unsupported for AVR, following the example of other such tests in the >> testsuite. > [...] Seems it has something to do with PR57821: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57821#c7 Maybe setting need_64bit_hwint for AVR target is able to make it pass the testcase, but I am not sure such change is correct for AVR port. Best regards, jasonwucj
diff --git gcc/testsuite/gcc.dg/torture/pr60183.c gcc/testsuite/gcc.dg/torture/pr60183.c index d37b4b8..8e519dc 100644 --- gcc/testsuite/gcc.dg/torture/pr60183.c +++ gcc/testsuite/gcc.dg/torture/pr60183.c @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-skip-if "Size of array too big" { "avr-*-*" } { "*" } { "" } } */ /* Large so an out-of-bound read will crash. */ unsigned char c[0x30001] = { 1 };