From patchwork Mon Feb 17 08:40:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 320877 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x23e.google.com (mail-ie0-x23e.google.com [IPv6:2607:f8b0:4001:c03::23e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 678F52C00D0 for ; Mon, 17 Feb 2014 19:40:45 +1100 (EST) Received: by mail-ie0-f190.google.com with SMTP id tp5sf161648ieb.7 for ; Mon, 17 Feb 2014 00:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=VebYkC8VxNy8QRCdpez99r2W/7WJz4ulYsla9r8l+To=; b=Eps2WNn9tkotonKSpZ7fhUXpCcshKEm2nxGkf5mLlQBf2RfNdZUmjkTqYZ3nYAcgTx /eMm5fk4V5X3J3om7O0pRQ2FCcO5ockjEVDoUXHy63HZxXM0ppADX8Kh9qtA2imn8TMM BkTsrv7dMUReSoXT0CEARHBAP59t0qH+YyRQ4EEmpjbYZ57pDxy1ji9u5yDxXWWJ3VcJ c7ZmpFb8KbD+v0nBSMSKBwUV7iDzUI7kY3qRgUMYvHVpYWLtbBdhBCdfQryDWNnMcjRQ gkeoAXcG0a9ERO9k1luA9ejHzUutPffUBraVDqKbweAOlJN9YLya+PtN6ECYtnG/kxKA D1Tw== X-Received: by 10.50.93.37 with SMTP id cr5mr289297igb.8.1392626442627; Mon, 17 Feb 2014 00:40:42 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.8.101 with SMTP id q5ls230088iga.38.gmail; Mon, 17 Feb 2014 00:40:42 -0800 (PST) X-Received: by 10.43.103.136 with SMTP id di8mr8485102icc.14.1392626442321; Mon, 17 Feb 2014 00:40:42 -0800 (PST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by gmr-mx.google.com with ESMTPS id sq4si2120895pbc.0.2014.02.17.00.40.42 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Mon, 17 Feb 2014 00:40:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of k.kozlowski@samsung.com designates 210.118.77.12 as permitted sender) client-ip=210.118.77.12; Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1400KMZTFNBN50@mailout2.w1.samsung.com> for rtc-linux@googlegroups.com; Mon, 17 Feb 2014 08:40:35 +0000 (GMT) X-AuditID: cbfec7f5-b7fc96d000004885-bd-5301cb08786c Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 7D.5D.18565.80BC1035; Mon, 17 Feb 2014 08:40:40 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N14007P7TFKT190@eusync2.samsung.com>; Mon, 17 Feb 2014 08:40:40 +0000 (GMT) From: Krzysztof Kozlowski To: Sangbeom Kim , Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa , Yadwinder Singh Brar , Krzysztof Kozlowski , Alessandro Zummo , rtc-linux@googlegroups.com Subject: [rtc-linux] [PATCH v3 04/13] rtc: s5m: Remove undocumented time init on first boot Date: Mon, 17 Feb 2014 09:40:18 +0100 Message-id: <1392626427-4518-5-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1392626427-4518-1-git-send-email-k.kozlowski@samsung.com> References: <1392626427-4518-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t/xK7ocpxmDDfZv5bRYcvEqu8XGGetZ LV6/MLQ42/SG3eL+16OMFpd3zWGzmHF+H5PF2iN32S32d3YwWpzuZrW4uOILk8X6Ga9ZLOZM f8fkwOuxZ+JJNo871/awecw7GejRt2UVo8f0eT+ZPD5vkgtgi+KySUnNySxLLdK3S+DKuPjk OHPBZYGK5z8nsDQwruXtYuTkkBAwkZj+toUVwhaTuHBvPVsXIxeHkMBSRonu4xPZQRJCAn1M Eq2fzUFsNgFjic3Ll4AViQhsZpRY/P0qWDezwAMmienPq0FsYQF/iePLN7OA2CwCqhKPJh9g BLF5Bdwkds29AjSUA2ibgsScSTYgYU4Bd4mnfVNZQcJCQCX7N4ZNYORdwMiwilE0tTS5oDgp PddIrzgxt7g0L10vOT93EyMkJL/uYFx6zOoQowAHoxIPr0E1Y7AQa2JZcWXuIUYJDmYlEV7b dUAh3pTEyqrUovz4otKc1OJDjEwcnFINjNNtTxapzSxOuLlvgdxMqeclCvdbMtcuDN6zXPDm J6Fvdadc3nbMFGkWPllmrCY4t6Csq+zBtml8O2M63Z1bBRU2n759u+O023LuzCuaN/Zq9Nok Hz9xIqd3W+DST8V/bS0mqj8QmfwqdE695pInZs+sVzzeet9RfOL+IuegwKtyTaXnO1QK3iix FGckGmoxFxUnAgDfoMYAJwIAAA== X-Original-Sender: k.kozlowski@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of k.kozlowski@samsung.com designates 210.118.77.12 as permitted sender) smtp.mail=k.kozlowski@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This patch removes the code for initializing time if this is first boot. The code for detecting first boot uses undocumented field RTC_TCON in RTC_UDR_CON register. According to S5M8767's datasheet this field is reserved. On S2MPS14 it is not documented at all. On device first boot the registers will be initialized with reset value (2000-01-01 00:00:00). The code might work on S5M8763 but still this does not look like a task for RTC driver. Signed-off-by: Krzysztof Kozlowski Cc: Alessandro Zummo Cc: rtc-linux@googlegroups.com --- drivers/rtc/rtc-s5m.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index d26e2480f8b3..b1627e9ab8f0 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -502,16 +502,7 @@ static void s5m_rtc_enable_smpl(struct s5m_rtc_info *info, bool enable) static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) { u8 data[2]; - unsigned int tp_read; int ret; - struct rtc_time tm; - - ret = regmap_read(info->regmap, S5M_RTC_UDR_CON, &tp_read); - if (ret < 0) { - dev_err(info->dev, "%s: fail to read control reg(%d)\n", - __func__, ret); - return ret; - } /* Set RTC control register : Binary mode, 24hour mode */ data[0] = (1 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); @@ -525,27 +516,6 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) return ret; } - /* In first boot time, Set rtc time to 1/1/2012 00:00:00(SUN) */ - if ((tp_read & RTC_TCON_MASK) == 0) { - dev_dbg(info->dev, "rtc init\n"); - tm.tm_sec = 0; - tm.tm_min = 0; - tm.tm_hour = 0; - tm.tm_wday = 0; - tm.tm_mday = 1; - tm.tm_mon = 0; - tm.tm_year = 112; - tm.tm_yday = 0; - tm.tm_isdst = 0; - ret = s5m_rtc_set_time(info->dev, &tm); - } - - ret = regmap_update_bits(info->regmap, S5M_RTC_UDR_CON, - RTC_TCON_MASK, tp_read | RTC_TCON_MASK); - if (ret < 0) - dev_err(info->dev, "%s: fail to update TCON reg(%d)\n", - __func__, ret); - return ret; }