Patchwork UBIFS: fix commentaries

login
register
mail settings
Submitter Artem Bityutskiy
Date Aug. 25, 2009, 3:27 p.m.
Message ID <1251214024-2777-1-git-send-email-dedekind@infradead.org>
Download mbox | patch
Permalink /patch/32074/
State New
Headers show

Comments

Artem Bityutskiy - Aug. 25, 2009, 3:27 p.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Change "write-back does take inode @i_mutex" to "write-back does not
take inode @i_mutex" type. IOW, this patch just adds "not" word, the
rest of the changes are just re-formatting to fit the 80 characters
line limit.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/file.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
Artem Bityutskiy - Aug. 27, 2009, 5:29 a.m.
On 08/25/2009 06:27 PM, Artem Bityutskiy wrote:
> From: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
>
> Change "write-back does take inode @i_mutex" to "write-back does not
> take inode @i_mutex" type. IOW, this patch just adds "not" word, the
> rest of the changes are just re-formatting to fit the 80 characters
> line limit.
>
> Signed-off-by: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>

Please, do not look at this patch. I'll create a different one at
some point.

Patch

diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 6d34dc7..ff43f60 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -965,12 +965,12 @@  static int do_writepage(struct page *page, int len)
  * and then keeps writing pages back.
  *
  * Some locking issues explanation. 'ubifs_writepage()' first is called with
- * the page locked, and it locks @ui_mutex. However, write-back does take inode
- * @i_mutex, which means other VFS operations may be run on this inode at the
- * same time. And the problematic one is truncation to smaller size, from where
- * we have to call 'vmtruncate()', which first changes @inode->i_size, then
- * drops the truncated pages. And while dropping the pages, it takes the page
- * lock. This means that 'do_truncation()' cannot call 'vmtruncate()' with
+ * the page locked, and it locks @ui_mutex. However, write-back does not take
+ * inode @i_mutex, which means other VFS operations may be run on this inode at
+ * the same time. And the problematic one is truncation to smaller size, from
+ * where we have to call 'vmtruncate()', which first changes @inode->i_size,
+ * then drops the truncated pages. And while dropping the pages, it takes the
+ * page lock. This means that 'do_truncation()' cannot call 'vmtruncate()' with
  * @ui_mutex locked, because it would deadlock with 'ubifs_writepage()'. This
  * means that @inode->i_size is changed while @ui_mutex is unlocked.
  *