| Message ID | 1392502403-19701-2-git-send-email-s.martin49@gmail.com |
|---|---|
| State | Accepted |
| Commit | 8e63d54e2ad7846f17f67079be8262f1deab7b7a |
| Headers | show |
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: > vlc can use opencv in video filters, but it requires a couple of > features enabled in opencv; so, simply force disabling opencv support. > Note that vlc does includes the legacy opencv/cv.h header, which pulls a > number of opencv's features (core, video, imgproc, ...). Is this meant as a short term fix for 2014.02? Presumably the user CAN enable the needed opencv option so it could work? - E.G. we could come up with the needed test like: ifeq ($(BR2_PACKAGE_OPENCV_FOO)$(BR2_PACKAGE_OPENCV_BLAH)...,yyy) VLC_CONF_OPT += --with-opencv VLC_DEPENDENCIES += opencv else VLC_CONF_OPT += --without-opencv endif > Fixes: > http://autobuild.buildroot.org/results/39c/39c77ffb5a5599d0b09422433c747b2bac185c4f/ > http://autobuild.buildroot.org/results/a79/a79b055da09e4d8ede263251df8461bc8a64569a/ > Signed-off-by: Samuel Martin <s.martin49@gmail.com> > --- > package/vlc/vlc.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk > index f235ff8..db99a3b 100644 > --- a/package/vlc/vlc.mk > +++ b/package/vlc/vlc.mk > @@ -30,7 +30,8 @@ VLC_CONF_OPT += \ > --disable-goom \ > --disable-projectm \ > --disable-vsxu \ > - --disable-mtp > + --disable-mtp \ > + --without-opencv > # Set powerpc altivec appropriately > ifeq ($(BR2_powerpc_7400)$(BR2_powerpc_7450)$(BR2_powerpc_970),y) > -- > 1.8.5.4 > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Peter, On Sun, Feb 16, 2014 at 9:17 AM, Peter Korsgaard <jacmet@uclibc.org> wrote: >>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: > > > vlc can use opencv in video filters, but it requires a couple of > > features enabled in opencv; so, simply force disabling opencv support. > > > Note that vlc does includes the legacy opencv/cv.h header, which pulls a > > number of opencv's features (core, video, imgproc, ...). > > Is this meant as a short term fix for 2014.02? Yes, it is a short term fix for the 2014.02 release, also because I don't think vlc package was added to buildroot with opencv support in mind... ;-) I just need some time to find all opencv's features used/required by vlc. > Presumably the user CAN > enable the needed opencv option so it could work? - E.G. we could come > up with the needed test like: > > ifeq ($(BR2_PACKAGE_OPENCV_FOO)$(BR2_PACKAGE_OPENCV_BLAH)...,yyy) > VLC_CONF_OPT += --with-opencv > VLC_DEPENDENCIES += opencv > else > VLC_CONF_OPT += --without-opencv > endif > Regards,
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: > vlc can use opencv in video filters, but it requires a couple of > features enabled in opencv; so, simply force disabling opencv support. > Note that vlc does includes the legacy opencv/cv.h header, which pulls a > number of opencv's features (core, video, imgproc, ...). > Fixes: > http://autobuild.buildroot.org/results/39c/39c77ffb5a5599d0b09422433c747b2bac185c4f/ > http://autobuild.buildroot.org/results/a79/a79b055da09e4d8ede263251df8461bc8a64569a/ > Signed-off-by: Samuel Martin <s.martin49@gmail.com> Committed, thanks.
diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk index f235ff8..db99a3b 100644 --- a/package/vlc/vlc.mk +++ b/package/vlc/vlc.mk @@ -30,7 +30,8 @@ VLC_CONF_OPT += \ --disable-goom \ --disable-projectm \ --disable-vsxu \ - --disable-mtp + --disable-mtp \ + --without-opencv # Set powerpc altivec appropriately ifeq ($(BR2_powerpc_7400)$(BR2_powerpc_7450)$(BR2_powerpc_970),y)
vlc can use opencv in video filters, but it requires a couple of features enabled in opencv; so, simply force disabling opencv support. Note that vlc does includes the legacy opencv/cv.h header, which pulls a number of opencv's features (core, video, imgproc, ...). Fixes: http://autobuild.buildroot.org/results/39c/39c77ffb5a5599d0b09422433c747b2bac185c4f/ http://autobuild.buildroot.org/results/a79/a79b055da09e4d8ede263251df8461bc8a64569a/ Signed-off-by: Samuel Martin <s.martin49@gmail.com> --- package/vlc/vlc.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)