| Message ID | 1392418457-3203-3-git-send-email-Larry.Finger@lwfinger.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote: > This alignment entry in union recv_frame does nothing. It certainly > dues not ensure alignment. ^ typo here. I accidently sent this as a private mail before, better to resend to the list. > > Suggested-by: Jes.Sorensen@redhat.com > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Jes.Sorensen@redhat.com > --- > drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h > index 866c9e4..c6d7a65 100644 > --- a/drivers/staging/rtl8188eu/include/rtw_recv.h > +++ b/drivers/staging/rtl8188eu/include/rtw_recv.h > @@ -292,7 +292,6 @@ struct recv_frame_hdr { > union recv_frame { > union { > struct recv_frame_hdr hdr; > - uint mem[RECVFRAME_HDR_ALIGN>>2]; > } u; > }; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 16, 2014 at 11:02:52AM +0800, Zhao, Gang wrote: > On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote: > > This alignment entry in union recv_frame does nothing. It certainly > > dues not ensure alignment. > ^ > typo here. > > I accidently sent this as a private mail before, better to resend to > the list. > This was already applied. You can still understand the meaning so it's fine. No need to redo. Typos in the code are more important. It's hard to run spell checkers on patches since so much of the words are code and not English. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/16/2014 03:09 AM, Dan Carpenter wrote: > On Sun, Feb 16, 2014 at 11:02:52AM +0800, Zhao, Gang wrote: >> On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote: >>> This alignment entry in union recv_frame does nothing. It certainly >>> dues not ensure alignment. >> ^ >> typo here. >> >> I accidently sent this as a private mail before, better to resend to >> the list. >> > > This was already applied. You can still understand the meaning so it's > fine. No need to redo. Typos in the code are more important. > > It's hard to run spell checkers on patches since so much of the words > are code and not English. In addition, this typo resulted in a correctly spelled word. It was just the wrong one. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 866c9e4..c6d7a65 100644 --- a/drivers/staging/rtl8188eu/include/rtw_recv.h +++ b/drivers/staging/rtl8188eu/include/rtw_recv.h @@ -292,7 +292,6 @@ struct recv_frame_hdr { union recv_frame { union { struct recv_frame_hdr hdr; - uint mem[RECVFRAME_HDR_ALIGN>>2]; } u; };
This alignment entry in union recv_frame does nothing. It certainly dues not ensure alignment. Suggested-by: Jes.Sorensen@redhat.com Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Jes.Sorensen@redhat.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - 1 file changed, 1 deletion(-)