Message ID | 1392384629-18771-7-git-send-email-yamada.m@jp.panasonic.com |
---|---|
State | Superseded |
Delegated to: | Jerry Van Baren |
Headers | show |
Hi.
> [PATCH 6/9] fdt_support: add 'const' qualifier for unchanged argument.
This might be really trivial, but I notice I had added a period at the
end of the subject by mistake.
Is it possible to remove it when this patch is applied?
Or need to post v2?
Best Regards
Masahiro Yamada
On Thu, Feb 20, 2014 at 05:55:47PM +0900, Masahiro Yamada wrote: > Hi. > > > > [PATCH 6/9] fdt_support: add 'const' qualifier for unchanged argument. > > This might be really trivial, but I notice I had added a period at the > end of the subject by mistake. > > Is it possible to remove it when this patch is applied? > Or need to post v2? I'll do my best to remember to fix it up.
Hi Tom, On Thu, 20 Feb 2014 08:31:56 -0500 Tom Rini <trini@ti.com> wrote: > On Thu, Feb 20, 2014 at 05:55:47PM +0900, Masahiro Yamada wrote: > > Hi. > > > > > > > [PATCH 6/9] fdt_support: add 'const' qualifier for unchanged argument. > > > > This might be really trivial, but I notice I had added a period at the > > end of the subject by mistake. > > > > Is it possible to remove it when this patch is applied? > > Or need to post v2? > > I'll do my best to remember to fix it up. > > -- > Tom When and by whom will my fdt_support series be reviewed? This series includes endian bug fixes (and various refactoring), so I believe it is worth the review. Best Regards Masahiro Yamada
diff --git a/common/fdt_support.c b/common/fdt_support.c index f641e68..bdc5ce1 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -21,11 +21,11 @@ * if #NNNN-cells property is 2 then len is 8 * otherwise len is 4 */ -static int get_cells_len(void *blob, char *nr_cells_name) +static int get_cells_len(const void *fdt, const char *nr_cells_name) { const fdt32_t *cell; - cell = fdt_getprop(blob, 0, nr_cells_name, NULL); + cell = fdt_getprop(fdt, 0, nr_cells_name, NULL); if (cell && fdt32_to_cpu(*cell) == 2) return 8;
In the next commit, I will add a new function, fdt_pack_reg() which uses get_cells_len(). Beforehand, this commit adds 'const' qualifier to get_cells_len(). Otherwise, a warning message will appear: warning: passing argument 1 of 'get_cells_len' discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> --- common/fdt_support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)