diff mbox

[v13,7/7] sdl: add support for top-level parallel make

Message ID 1392371709-26662-8-git-send-email-fabio.porcedda@gmail.com
State Accepted
Commit 060623cfed26aa23da7ba1e40cd3e0472eca5fb9
Headers show

Commit Message

Fabio Porcedda Feb. 14, 2014, 9:55 a.m. UTC
To be sure that host-autoconf dependency is already built move the
call to autogen.sh from SDL_POST_PATCH_HOOKS to SDL_PRE_CONFIGURE_HOOKS.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/sdl/sdl.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Hadjinlian Feb. 14, 2014, 1:46 p.m. UTC | #1
Hi Fabio, all
On Fri, Feb 14, 2014 at 10:55 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> To be sure that host-autoconf dependency is already built move the
> call to autogen.sh from SDL_POST_PATCH_HOOKS to SDL_PRE_CONFIGURE_HOOKS.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  package/sdl/sdl.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index ba5fbca..cf3366d 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -17,7 +17,7 @@ define SDL_RUN_AUTOGEN
>         cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh
>  endef
>
> -SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN
> +SDL_PRE_CONFIGURE_HOOKS += SDL_RUN_AUTOGEN
>  SDL_DEPENDENCIES += host-automake host-autoconf host-libtool
>
>
> --
> 1.8.5.2
>
I agree with Thomas, it make much more sense in this hook.
I will then resend my patch adding the host variant of sdl.

Acked-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
diff mbox

Patch

diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
index ba5fbca..cf3366d 100644
--- a/package/sdl/sdl.mk
+++ b/package/sdl/sdl.mk
@@ -17,7 +17,7 @@  define SDL_RUN_AUTOGEN
 	cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh
 endef
 
-SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN
+SDL_PRE_CONFIGURE_HOOKS += SDL_RUN_AUTOGEN
 SDL_DEPENDENCIES += host-automake host-autoconf host-libtool