| Message ID | 4A93895F.4010708@cn.fujitsu.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
* Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: > Currently, the napi's tracepoint works will is depend on > "DECLARE_TRACE" definiens in include/trace/define_trace.h, > like below: > > #include <trace/events/skb.h> // include define_trace.h > #include <trace/events/napi.h> > > there have error, if we remove "#include <trace/events/skb.h>" > or include napi.h in the front of include skb.h, It should > depend on the definiens in include/linux/tracepoint.h and we > can remove the "DECLARE_TRACE" definiens in > include/trace/define_trace.h, because "TRACE_EVENT" not use it > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > --- > include/trace/define_trace.h | 4 ---- > net/core/net-traces.c | 4 +++- > 2 files changed, 3 insertions(+), 5 deletions(-) This will collide with tracing bits in the networking tree. The skb-tracing plugin there should be turned into proper TRACE_EVENT() tracepoints. Neil was away for some time but i think soon we should see some movement here. Ingo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 25, 2009 at 09:58:16AM +0200, Ingo Molnar wrote: > > * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: > > > Currently, the napi's tracepoint works will is depend on > > "DECLARE_TRACE" definiens in include/trace/define_trace.h, > > like below: > > > > #include <trace/events/skb.h> // include define_trace.h > > #include <trace/events/napi.h> > > > > there have error, if we remove "#include <trace/events/skb.h>" > > or include napi.h in the front of include skb.h, It should > > depend on the definiens in include/linux/tracepoint.h and we > > can remove the "DECLARE_TRACE" definiens in > > include/trace/define_trace.h, because "TRACE_EVENT" not use it > > > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > --- > > include/trace/define_trace.h | 4 ---- > > net/core/net-traces.c | 4 +++- > > 2 files changed, 3 insertions(+), 5 deletions(-) > > This will collide with tracing bits in the networking tree. The > skb-tracing plugin there should be turned into proper TRACE_EVENT() > tracepoints. > > Neil was away for some time but i think soon we should see some > movement here. > > Ingo > Thank you Ingo, yes, I'm back from the beach now and will look at this shortly. I concur, we should just convert the napi_poll tracepoint to be defined via the TRACE_EVENT macro, same as the kfree_skb tracepoint. Xaio would you like to take care of that, or shall I? Best Neil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Neil Horman wrote: > On Tue, Aug 25, 2009 at 09:58:16AM +0200, Ingo Molnar wrote: >> * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: >> >> This will collide with tracing bits in the networking tree. The >> skb-tracing plugin there should be turned into proper TRACE_EVENT() >> tracepoints. >> >> Neil was away for some time but i think soon we should see some >> movement here. >> >> Ingo >> > > Thank you Ingo, yes, I'm back from the beach now and will look at this shortly. > I concur, we should just convert the napi_poll tracepoint to be defined via the > TRACE_EVENT macro, same as the kfree_skb tracepoint. Xaio would you like to > take care of that, or shall I? > Hi Neil, I'm glad to do it. Actually, we should fix the include file dependencies first (the second patch in this patchset), else we can't include two TRACE_EVENT head files in net-traces.c Steve will pull this patchset, so, I'll convert it after this patchset merged. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Xiao Guangrong wrote: > Currently, the napi's tracepoint works will is depend on > "DECLARE_TRACE" definiens in include/trace/define_trace.h, > like below: > > #include <trace/events/skb.h> // include define_trace.h > #include <trace/events/napi.h> > > there have error, if we remove "#include <trace/events/skb.h>" > or include napi.h in the front of include skb.h, It should > depend on the definiens in include/linux/tracepoint.h and we > can remove the "DECLARE_TRACE" definiens in > include/trace/define_trace.h, because "TRACE_EVENT" not use it > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> Hi Steven, I'm sorry, please pull this patch too, because "[PATCH 7/8] tracing/events: fix the include file dependencies" is based on this patch, else will occur building error. Thanks, Xiao -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Xiao Guangrong wrote: > > Xiao Guangrong wrote: >> Currently, the napi's tracepoint works will is depend on >> "DECLARE_TRACE" definiens in include/trace/define_trace.h, >> like below: >> >> #include <trace/events/skb.h> // include define_trace.h >> #include <trace/events/napi.h> >> >> there have error, if we remove "#include <trace/events/skb.h>" >> or include napi.h in the front of include skb.h, It should >> depend on the definiens in include/linux/tracepoint.h and we >> can remove the "DECLARE_TRACE" definiens in >> include/trace/define_trace.h, because "TRACE_EVENT" not use it >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > Hi Steven, > > I'm sorry, please pull this patch too, because > "[PATCH 7/8] tracing/events: fix the include file dependencies" > is based on this patch, else will occur building error. > Sorry again, I say the wrong words, it not has building error, just not complete fix the bug which I mention it in the changelog of "[PATCH 7/8] tracing/events: fix the include file dependencies", that is we can't include more TRACE_EVENT head file in .c file all the same, like below: Both define TRACE_EVENT in trace_a.h and trace_b.h, if we include those in .c file, like this: #define CREATE_TRACE_POINTS include <trace/events/trace_a.h> // re-define DECLARE_TRACE include <trace/events/trace_b.h> // use the DECLARE_TRACE definition // that re-define by trace_a.h Thanks, Xiao -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 26 Aug 2009, Xiao Guangrong wrote: > > > Xiao Guangrong wrote: > > > > Xiao Guangrong wrote: > >> Currently, the napi's tracepoint works will is depend on > >> "DECLARE_TRACE" definiens in include/trace/define_trace.h, > >> like below: > >> > >> #include <trace/events/skb.h> // include define_trace.h > >> #include <trace/events/napi.h> > >> > >> there have error, if we remove "#include <trace/events/skb.h>" > >> or include napi.h in the front of include skb.h, It should > >> depend on the definiens in include/linux/tracepoint.h and we > >> can remove the "DECLARE_TRACE" definiens in > >> include/trace/define_trace.h, because "TRACE_EVENT" not use it > >> > >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > > > Hi Steven, > > > > I'm sorry, please pull this patch too, because > > "[PATCH 7/8] tracing/events: fix the include file dependencies" > > is based on this patch, else will occur building error. > > > > Sorry again, I say the wrong words, it not has building error, just > not complete fix the bug which I mention it in the changelog of > "[PATCH 7/8] tracing/events: fix the include file dependencies", that > is we can't include more TRACE_EVENT head file in .c file all the same, > like below: > > Both define TRACE_EVENT in trace_a.h and trace_b.h, if we include > those in .c file, like this: > > #define CREATE_TRACE_POINTS > include <trace/events/trace_a.h> // re-define DECLARE_TRACE > > include <trace/events/trace_b.h> // use the DECLARE_TRACE definition > // that re-define by trace_a.h Hi Xiao, I pushed out the "fix the include file dependencies" patch since that was a bug fix in its own right. I held off the NAPI patch because it looked like it needed rework and only depended on the include dependencies fix. Could you update this code to do as Neil and Ingo has mentioned. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h index f7a7ae1..76e93bf 100644 --- a/include/trace/define_trace.h +++ b/include/trace/define_trace.h @@ -26,10 +26,6 @@ #define TRACE_EVENT(name, proto, args, tstruct, assign, print) \ DEFINE_TRACE(name) -#undef DECLARE_TRACE -#define DECLARE_TRACE(name, proto, args) \ - DEFINE_TRACE(name) - #undef TRACE_INCLUDE #undef __TRACE_INCLUDE diff --git a/net/core/net-traces.c b/net/core/net-traces.c index f1e982c..42bda72 100644 --- a/net/core/net-traces.c +++ b/net/core/net-traces.c @@ -19,13 +19,15 @@ #include <linux/workqueue.h> #include <linux/netlink.h> #include <linux/net_dropmon.h> +#include <linux/tracepoint.h> #include <asm/unaligned.h> #include <asm/bitops.h> #define CREATE_TRACE_POINTS #include <trace/events/skb.h> -#include <trace/events/napi.h> + +DEFINE_TRACE(napi_poll); EXPORT_TRACEPOINT_SYMBOL_GPL(kfree_skb);
Currently, the napi's tracepoint works will is depend on "DECLARE_TRACE" definiens in include/trace/define_trace.h, like below: #include <trace/events/skb.h> // include define_trace.h #include <trace/events/napi.h> there have error, if we remove "#include <trace/events/skb.h>" or include napi.h in the front of include skb.h, It should depend on the definiens in include/linux/tracepoint.h and we can remove the "DECLARE_TRACE" definiens in include/trace/define_trace.h, because "TRACE_EVENT" not use it Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- include/trace/define_trace.h | 4 ---- net/core/net-traces.c | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-)