mbox

[PULL,0/3] s390-ccw.img: fix sporadic boot errors

Message ID 1392283031-40129-1-git-send-email-borntraeger@de.ibm.com
State New
Headers show

Pull-request

git://github.com/borntraeger/qemu.git tags/ipl-20140213

Message

Christian Borntraeger Feb. 13, 2014, 9:17 a.m. UTC
Peter, Anthony,

The following changes since commit 9d74f6fef0801ca2ce5c9d38d59b85bf03c27669:

  Merge remote-tracking branch 'remotes/alon/pull-libcacard.glusterfs' into staging (2014-02-12 17:53:31 +0000)

are available in the git repository at:


  git://github.com/borntraeger/qemu.git tags/ipl-20140213

for you to fetch changes up to 669d13daaf31e81463d081f59ee88e4f75dc7538:

  s390-ccw.img: new binary rom to match latest fixes (2014-02-13 09:59:21 +0100)


These changes make the reipl more robust.
----------------------------------------------------------------
This fixes two sporadic errors on reboot when the s390-ccw.img
is used. Both problems are related to qemus elf loader only caring
about PT_LOAD sections: This results in a non-zero bss section
after reboot. This makes static variables non-zero.

This quick fix initializes all variables. Long term we might
also want to clear out the bss section.

----------------------------------------------------------------
Christian Borntraeger (3):
      s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx
      s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css
      s390-ccw.img: new binary rom to match latest fixes

 pc-bios/s390-ccw.img      | Bin 9336 -> 9336 bytes
 pc-bios/s390-ccw/main.c   |   3 +--
 pc-bios/s390-ccw/virtio.c |   1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Maydell Feb. 13, 2014, 9:21 a.m. UTC | #1
On 13 February 2014 09:17, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Peter, Anthony,
>
> The following changes since commit 9d74f6fef0801ca2ce5c9d38d59b85bf03c27669:
>
>   Merge remote-tracking branch 'remotes/alon/pull-libcacard.glusterfs' into staging (2014-02-12 17:53:31 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/borntraeger/qemu.git tags/ipl-20140213
>
> for you to fetch changes up to 669d13daaf31e81463d081f59ee88e4f75dc7538:
>
>   s390-ccw.img: new binary rom to match latest fixes (2014-02-13 09:59:21 +0100)
>
>
> These changes make the reipl more robust.
> ----------------------------------------------------------------
> This fixes two sporadic errors on reboot when the s390-ccw.img
> is used. Both problems are related to qemus elf loader only caring
> about PT_LOAD sections: This results in a non-zero bss section
> after reboot. This makes static variables non-zero.
>
> This quick fix initializes all variables. Long term we might
> also want to clear out the bss section.
>
> ----------------------------------------------------------------
> Christian Borntraeger (3):
>       s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx
>       s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css
>       s390-ccw.img: new binary rom to match latest fixes

I couldn't find these patches anywhere on the list when I searched
my archives -- have they been through the usual review process?

thanks
-- PMM
Christian Borntraeger Feb. 13, 2014, 9:26 a.m. UTC | #2
On 13/02/14 10:21, Peter Maydell wrote:
> On 13 February 2014 09:17, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> Peter, Anthony,
>>
>> The following changes since commit 9d74f6fef0801ca2ce5c9d38d59b85bf03c27669:
>>
>>   Merge remote-tracking branch 'remotes/alon/pull-libcacard.glusterfs' into staging (2014-02-12 17:53:31 +0000)
>>
>> are available in the git repository at:
>>
>>
>>   git://github.com/borntraeger/qemu.git tags/ipl-20140213
>>
>> for you to fetch changes up to 669d13daaf31e81463d081f59ee88e4f75dc7538:
>>
>>   s390-ccw.img: new binary rom to match latest fixes (2014-02-13 09:59:21 +0100)
>>
>>
>> These changes make the reipl more robust.
>> ----------------------------------------------------------------
>> This fixes two sporadic errors on reboot when the s390-ccw.img
>> is used. Both problems are related to qemus elf loader only caring
>> about PT_LOAD sections: This results in a non-zero bss section
>> after reboot. This makes static variables non-zero.
>>
>> This quick fix initializes all variables. Long term we might
>> also want to clear out the bss section.
>>
>> ----------------------------------------------------------------
>> Christian Borntraeger (3):
>>       s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx
>>       s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css
>>       s390-ccw.img: new binary rom to match latest fixes
> 
> I couldn't find these patches anywhere on the list when I searched
> my archives -- have they been through the usual review process?

You are right, not yet on qemu-devel. Since these patches are also part
of the mail thread, lets just wait some days and let also wait for
Alex' NACK/ACK.

Christian