From patchwork Thu Feb 13 09:13:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 319922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ie0-x239.google.com (mail-ie0-x239.google.com [IPv6:2607:f8b0:4001:c03::239]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 679D02C0096 for ; Thu, 13 Feb 2014 20:14:30 +1100 (EST) Received: by mail-ie0-f185.google.com with SMTP id rd18sf176855iec.22 for ; Thu, 13 Feb 2014 01:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=VebYkC8VxNy8QRCdpez99r2W/7WJz4ulYsla9r8l+To=; b=Nhwj+Z9B2AZ1l6XmKLYk894WOr/VBd1+60LeFmBMTKQgvj64tSBwgVboX8/OSdAlmN kZBla6a0SZo+B7oimDQFNsqUEG3IH6RhFvH2XGBLiVCNUIn/BCvUosRH/CUDXd/i9cTJ y5yZFdWrMir8lCrIZOxluYRyhrLW5IfZpPT0qS9gB/nNPJbqbP2/2KeFSWHO7RkkYk/Y IT56GSovoK3Bxry6znh0mvMdf0PeLz2ipTPErnRpk8uHZj1+LYwpYpCl7qyYhWANr8mx Q0JLyl0lsXvvvfG0ljhd2u6kXNEsbqBiXkAUh3t+d+0WQAxpeKGgTpR+tOjft4OfdQ3q 9/KQ== X-Received: by 10.140.25.242 with SMTP id 105mr11650qgt.8.1392282866753; Thu, 13 Feb 2014 01:14:26 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.140.40.11 with SMTP id w11ls3497965qgw.42.gmail; Thu, 13 Feb 2014 01:14:26 -0800 (PST) X-Received: by 10.52.29.16 with SMTP id f16mr135849vdh.8.1392282865994; Thu, 13 Feb 2014 01:14:25 -0800 (PST) Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com. [210.118.77.13]) by gmr-mx.google.com with ESMTPS id rf7si446920pab.2.2014.02.13.01.14.25 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Thu, 13 Feb 2014 01:14:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of k.kozlowski@samsung.com designates 210.118.77.13 as permitted sender) client-ip=210.118.77.13; Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0X00EDTGC0JO40@mailout3.w1.samsung.com> for rtc-linux@googlegroups.com; Thu, 13 Feb 2014 09:14:24 +0000 (GMT) X-AuditID: cbfec7f4-b7f796d000005a13-93-52fc8cefee91 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 67.3D.23059.FEC8CF25; Thu, 13 Feb 2014 09:14:23 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N0X002E0GBT6O90@eusync1.samsung.com>; Thu, 13 Feb 2014 09:14:23 +0000 (GMT) From: Krzysztof Kozlowski To: Sangbeom Kim , Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alessandro Zummo , rtc-linux@googlegroups.com Subject: [rtc-linux] [PATCH v2 04/14] rtc: s5m: Remove undocumented time init on first boot Date: Thu, 13 Feb 2014 10:13:57 +0100 Message-id: <1392282847-25444-5-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1392282847-25444-1-git-send-email-k.kozlowski@samsung.com> References: <1392282847-25444-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Zd33PX+CDCbdUbNYcvEqu8XGGetZ LV6/MLQ42/SG3eL+16OMFpd3zWGzmHF+H5PF2iN32S32d3YwWpzuZrW4uOILkwO3x56JJ9k8 7lzbw+Yx72SgR9+WVYwe0+f9ZPL4vEkugC2KyyYlNSezLLVI3y6BK+Pik+PMBZcFKp7/nMDS wLiWt4uRk0NCwERiz5yFzBC2mMSFe+vZuhi5OIQEljJKvGk/DeX0MUmc+nmEFaSKTcBYYvPy JWAJEYHNjBKLv19lBXGYBXqYJK61z2UBqRIW8Jf41zgPrINFQFVix5t2sDivgLvEvqVfmLoY OYD2KUjMmWQDEuYU8JD49+M32BlCQCU9i2exT2DkXcDIsIpRNLU0uaA4KT3XUK84Mbe4NC9d Lzk/dxMjJAi/7GBcfMzqEKMAB6MSD6/Fst9BQqyJZcWVuYcYJTiYlUR4ZST+BAnxpiRWVqUW 5ccXleakFh9iZOLglGpgbLdepVyzJGJi0Jzb2StrZ3/81dbmeCaiL9Vd4Xic9CyRTTvevo8N OP5A2qltsujE0v+7dx32NLr5pYS90va48dz+38vnTej79C7C8IHv7VPzdv9mr6/v5vg+T3hN uE95W5JBJROfqR5H3/P4Q5wLIh5FTtRyEL7eZpRus+7hxD8Bd/aqO+a9U2Ipzkg01GIuKk4E AG8fCKQgAgAA X-Original-Sender: k.kozlowski@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of k.kozlowski@samsung.com designates 210.118.77.13 as permitted sender) smtp.mail=k.kozlowski@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This patch removes the code for initializing time if this is first boot. The code for detecting first boot uses undocumented field RTC_TCON in RTC_UDR_CON register. According to S5M8767's datasheet this field is reserved. On S2MPS14 it is not documented at all. On device first boot the registers will be initialized with reset value (2000-01-01 00:00:00). The code might work on S5M8763 but still this does not look like a task for RTC driver. Signed-off-by: Krzysztof Kozlowski Cc: Alessandro Zummo Cc: rtc-linux@googlegroups.com --- drivers/rtc/rtc-s5m.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index d26e2480f8b3..b1627e9ab8f0 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -502,16 +502,7 @@ static void s5m_rtc_enable_smpl(struct s5m_rtc_info *info, bool enable) static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) { u8 data[2]; - unsigned int tp_read; int ret; - struct rtc_time tm; - - ret = regmap_read(info->regmap, S5M_RTC_UDR_CON, &tp_read); - if (ret < 0) { - dev_err(info->dev, "%s: fail to read control reg(%d)\n", - __func__, ret); - return ret; - } /* Set RTC control register : Binary mode, 24hour mode */ data[0] = (1 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); @@ -525,27 +516,6 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) return ret; } - /* In first boot time, Set rtc time to 1/1/2012 00:00:00(SUN) */ - if ((tp_read & RTC_TCON_MASK) == 0) { - dev_dbg(info->dev, "rtc init\n"); - tm.tm_sec = 0; - tm.tm_min = 0; - tm.tm_hour = 0; - tm.tm_wday = 0; - tm.tm_mday = 1; - tm.tm_mon = 0; - tm.tm_year = 112; - tm.tm_yday = 0; - tm.tm_isdst = 0; - ret = s5m_rtc_set_time(info->dev, &tm); - } - - ret = regmap_update_bits(info->regmap, S5M_RTC_UDR_CON, - RTC_TCON_MASK, tp_read | RTC_TCON_MASK); - if (ret < 0) - dev_err(info->dev, "%s: fail to update TCON reg(%d)\n", - __func__, ret); - return ret; }