| Message ID | 1392220985-28189-1-git-send-email-lee.jones@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Feb 12, 2014 at 04:03:02PM +0000, Lee Jones wrote: > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > devices. It has 2 ports which it can use for either; both SATA, both > PCIe or one of each in any configuration. > > Cc: devicetree@vger.kernel.org > Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > new file mode 100644 > index 0000000..fdfa7ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > @@ -0,0 +1,43 @@ > +STMicroelectronics STi MIPHY365x PHY binding > +============================================ > + > +This binding describes a miphy device that is used to control PHY hardware > +for SATA and PCIe. > + > +Required properties: > +- compatible: Should be "st,miphy365x-phy" > +- #phy-cells: Should be 2 (See example) The first example has #phy-cells = <1>. What do the cells mean? What are the expected values? > +- reg: Address and length of the register set for the device > +- reg-names: The names of the register addresses corresponding to the > + registers filled in "reg". Whenever there is a ${PROP}-names property, there should be a list of explicit values, and a description of how it relates to ${PROP}. Without that it's a bit useless. Please provide an explicit list of expected names here. I assume here what you want is something like: - reg: a list of address + length pairs, one for each entry in reg-names - reg-names: should contain: * "sata0" for the sata0 control registers... * "sata1" ... * "pcie0" ... * "pcie1" ... > +- st,syscfg : Should be a phandle of the syscfg node. What's this used for? Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > > devices. It has 2 ports which it can use for either; both SATA, both > > PCIe or one of each in any configuration. > > > > Cc: devicetree@vger.kernel.org > > Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > new file mode 100644 > > index 0000000..fdfa7ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > @@ -0,0 +1,43 @@ > > +STMicroelectronics STi MIPHY365x PHY binding > > +============================================ > > + > > +This binding describes a miphy device that is used to control PHY hardware > > +for SATA and PCIe. > > + > > +Required properties: > > +- compatible: Should be "st,miphy365x-phy" > > +- #phy-cells: Should be 2 (See example) > > The first example has #phy-cells = <1>. Right, will fix. Should be 2. > What do the cells mean? What are the expected values? http://www.spinics.net/lists/arm-kernel/msg307209.html > > +- reg: Address and length of the register set for the device > > +- reg-names: The names of the register addresses corresponding to the > > + registers filled in "reg". > > Whenever there is a ${PROP}-names property, there should be a list of > explicit values, and a description of how it relates to ${PROP}. Without > that it's a bit useless. > > Please provide an explicit list of expected names here. > > I assume here what you want is something like: > > - reg: a list of address + length pairs, one for each entry in reg-names > - reg-names: should contain: > * "sata0" for the sata0 control registers... > * "sata1" ... > * "pcie0" ... > * "pcie1" ... Can do. > > +- st,syscfg : Should be a phandle of the syscfg node. > > What's this used for? It's used to gain access to the system configuration registers. Specifically in this case the bits to choose between PCI or SATA mode.
On Thu, Feb 13, 2014 at 11:03:14AM +0000, Lee Jones wrote: > > > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > > > devices. It has 2 ports which it can use for either; both SATA, both > > > PCIe or one of each in any configuration. > > > > > > Cc: devicetree@vger.kernel.org > > > Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ > > > 1 file changed, 43 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > new file mode 100644 > > > index 0000000..fdfa7ca > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt > > > @@ -0,0 +1,43 @@ > > > +STMicroelectronics STi MIPHY365x PHY binding > > > +============================================ > > > + > > > +This binding describes a miphy device that is used to control PHY hardware > > > +for SATA and PCIe. > > > + > > > +Required properties: > > > +- compatible: Should be "st,miphy365x-phy" > > > +- #phy-cells: Should be 2 (See example) > > > > The first example has #phy-cells = <1>. > > Right, will fix. Should be 2. > > > What do the cells mean? What are the expected values? > > http://www.spinics.net/lists/arm-kernel/msg307209.html Ok. Could that be mentioned in the binding document then? Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/phy-miphy365x.txt b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt new file mode 100644 index 0000000..fdfa7ca --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-miphy365x.txt @@ -0,0 +1,43 @@ +STMicroelectronics STi MIPHY365x PHY binding +============================================ + +This binding describes a miphy device that is used to control PHY hardware +for SATA and PCIe. + +Required properties: +- compatible: Should be "st,miphy365x-phy" +- #phy-cells: Should be 2 (See example) +- reg: Address and length of the register set for the device +- reg-names: The names of the register addresses corresponding to the + registers filled in "reg". +- st,syscfg : Should be a phandle of the syscfg node. + +Example: + + miphy365x_phy: miphy365x@0 { + compatible = "st,miphy365x-phy"; + #phy-cells = <1>; + reg = <0xfe382000 0x100>, + <0xfe38a000 0x100>, + <0xfe394000 0x100>, + <0xfe804000 0x100>; + reg-names = "sata0", "sata1", "pcie0", "pcie1"; + st,syscfg= <&syscfg_rear>; + }; + +Specifying phy control of devices +================================= + +Device nodes should specify the configuration required in their "phys" +property, containing a phandle to the miphy device node, a port number +and a device type. + +Example: + +#include <dt-bindings/phy/phy-miphy365x.h> + + sata0: sata@fe380000 { + ... + phys = <&miphy365x_phy MIPHY_PORT_0 MIPHY_TYPE_SATA>; + ... + };
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe devices. It has 2 ports which it can use for either; both SATA, both PCIe or one of each in any configuration. Cc: devicetree@vger.kernel.org Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- .../devicetree/bindings/phy/phy-miphy365x.txt | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/phy-miphy365x.txt