| Message ID | 20140212154559.2405.3104.stgit@warthog.procyon.org.uk |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
From: David Howells <dhowells@redhat.com> Date: Wed, 12 Feb 2014 15:45:59 +0000 > sparc_cpu_model isn't in asm/system.h any more, so remove a comment about it. > > Signed-off-by: David Howells <dhowells@redhat.com> That's not all your patch does: > - /* extern enum sparc_cpu sparc_cpu_model; */ /* in <asm/system.h> */ > - if (sparc_cpu_model != sun4m) { > + if (sparc_cpu_model != sun4m) > /* We must be on sun4m because we use MMU Bypass ASI. */ > return -ENXIO; > - } The basic block is more than one line, therefore the braces are appropriate. Please do not remove them, and especially do not remove them without mentioning them in the commit message. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/sbus/char/jsflash.c b/drivers/sbus/char/jsflash.c index 6b4678a..018b64b 100644 --- a/drivers/sbus/char/jsflash.c +++ b/drivers/sbus/char/jsflash.c @@ -507,11 +507,9 @@ static int jsflash_init(void) } /* Let us be really paranoid for modifications to probing code. */ - /* extern enum sparc_cpu sparc_cpu_model; */ /* in <asm/system.h> */ - if (sparc_cpu_model != sun4m) { + if (sparc_cpu_model != sun4m) /* We must be on sun4m because we use MMU Bypass ASI. */ return -ENXIO; - } if (jsf0.base == 0) { jsf = &jsf0;
sparc_cpu_model isn't in asm/system.h any more, so remove a comment about it. Signed-off-by: David Howells <dhowells@redhat.com> cc: "David S. Miller" <davem@davemloft.net> cc: sparclinux@vger.kernel.org --- drivers/sbus/char/jsflash.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html