Message ID | 1392168462-18888-2-git-send-email-f.fainelli@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series applied, but this patch series had several problems which I want you absolutely to correct in future submissions. First of all, when you submit more than one patch at a time, you must provide a leading "PATCH 00/NN" posting which gives a top-level, detailed, description of the overall nature of the changes you are submitting. It also gives me a single, specific, posting to reply to when I reply the whole series. Otherwise I have only two options, 1) pick an arbitrary patch to reply to (which I am doing right now) or 2) reply to every single patch (which is a serious waste of everyone's time). Furthermore, some of your patches added empty lines to the end of files. I corrected this by hand, but please avoid this in the future. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2014-02-12 16:13 GMT-08:00 David Miller <davem@davemloft.net>: > > Series applied, but this patch series had several problems which I want you > absolutely to correct in future submissions. > > First of all, when you submit more than one patch at a time, you must > provide a leading "PATCH 00/NN" posting which gives a top-level, > detailed, description of the overall nature of the changes you are > submitting. Weird, did not you receive this cover-letter: http://permalink.gmane.org/gmane.linux.network/303496 if not, that probably explains why the threading was all messed up in your inbox. > > It also gives me a single, specific, posting to reply to when I reply > the whole series. Otherwise I have only two options, 1) pick an > arbitrary patch to reply to (which I am doing right now) or 2) reply > to every single patch (which is a serious waste of everyone's time). > > Furthermore, some of your patches added empty lines to the end of files. > I corrected this by hand, but please avoid this in the future. Thanks! > > Thank you. >
From: Florian Fainelli <f.fainelli@gmail.com> Date: Wed, 12 Feb 2014 16:20:19 -0800 > 2014-02-12 16:13 GMT-08:00 David Miller <davem@davemloft.net>: >> >> Series applied, but this patch series had several problems which I want you >> absolutely to correct in future submissions. >> >> First of all, when you submit more than one patch at a time, you must >> provide a leading "PATCH 00/NN" posting which gives a top-level, >> detailed, description of the overall nature of the changes you are >> submitting. > > Weird, did not you receive this cover-letter: > http://permalink.gmane.org/gmane.linux.network/303496 > if not, that probably explains why the threading was all messed up in > your inbox. Weird indeed, I'll watch out for this in the future. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 19c9eca..c35b2e7 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -45,12 +45,11 @@ void phy_print_status(struct phy_device *phydev) { if (phydev->link) { - pr_info("%s - Link is Up - %d/%s\n", - dev_name(&phydev->dev), + netdev_info(phydev->attached_dev, "Link is Up - %d/%s\n", phydev->speed, DUPLEX_FULL == phydev->duplex ? "Full" : "Half"); } else { - pr_info("%s - Link is Down\n", dev_name(&phydev->dev)); + netdev_info(phydev->attached_dev, "Link is Down\n"); } } EXPORT_SYMBOL(phy_print_status);
phy_print_status() currently uses dev_name(&phydev->dev) which will usually result in printing something along those lines for Device Tree aware drivers: libphy: f0b60000.etherne:0a - Link is Down libphy: f0ba0000.etherne:00 - Link is Up - 1000/Full This is not terribly useful for network administrators or users since we expect a network interface name to be able to correlate link events with interfaces. Update phy_print_status() to use netdev_info() with phydev->attached_dev which is the backing network device for our PHY device. The leading dash is removed since netdev_info() prefixes the messages with "<interface>: " already. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/net/phy/phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)