From patchwork Mon Aug 24 04:38:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Beregalov X-Patchwork-Id: 31891 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id CA525B708B for ; Mon, 24 Aug 2009 14:40:29 +1000 (EST) Received: by ozlabs.org (Postfix) id BD9CBDDD0B; Mon, 24 Aug 2009 14:40:29 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4FB0FDDD01 for ; Mon, 24 Aug 2009 14:40:29 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751505AbZHXEim (ORCPT ); Mon, 24 Aug 2009 00:38:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751375AbZHXEil (ORCPT ); Mon, 24 Aug 2009 00:38:41 -0400 Received: from mail-ew0-f207.google.com ([209.85.219.207]:49275 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbZHXEie (ORCPT ); Mon, 24 Aug 2009 00:38:34 -0400 Received: by ewy3 with SMTP id 3so2050239ewy.18 for ; Sun, 23 Aug 2009 21:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=GJHwMGRUCj9B0gJ1Sa5CGG9A18YMTiaZIb5vxlzet0Q=; b=moP5QVj+Wj4YUXTTa3lPXqet41Y66Haa7+QDze04mfv1oNVfw+m7neN7LJy6qOMjfJ ZwLuNavLFofPmXSLY7Ay8u9l3wF2vxjWFL1JDHUYP3lAwUl72qoe1VsVw8I8/MeYd6Ni wGd4hPm4dbMqrCwUWZrrZqf34oPc52oDggNbY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Fv5Q6FFtwi4oWtcxNOBrWI2aP81XPXE/qotzkfevk5nfxLQ3rUoeNzwQTLsbMAHL2v JvPRUJx9YxZqbUEE98y8y5ySFKQ2h+LRmmzZN0zJhAKd8c1J77MH8I4ymK42ExUnqokp S0IxJjkjc8DUc2qWmoo/Mf1NL0J8ins7t+r+w= Received: by 10.210.137.16 with SMTP id k16mr3272297ebd.16.1251088714735; Sun, 23 Aug 2009 21:38:34 -0700 (PDT) Received: from orion (ppp85-140-247-219.pppoe.mtu-net.ru [85.140.247.219]) by mx.google.com with ESMTPS id 7sm3792116eyb.7.2009.08.23.21.38.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 23 Aug 2009 21:38:34 -0700 (PDT) Date: Mon, 24 Aug 2009 08:38:31 +0400 From: Alexander Beregalov To: David Miller Cc: eric.y.miao@gmail.com, linux-arm-kernel@lists.arm.linux.org.uk, linux@arm.linux.org.uk, samuel@sortiz.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, marek.vasut@gmail.com Subject: Re: [PATCH] pxaficp-ir - remove incorrect net_device_ops Message-ID: <20090824043831.GA2473@orion> References: <200908051602.34501.marek.vasut@gmail.com> <200908220054.31438.marek.vasut@gmail.com> <20090823.184924.26788268.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090823.184924.26788268.davem@davemloft.net> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote: > From: Alexander Beregalov > Date: Sun, 23 Aug 2009 21:55:45 +0400 > > > David, please have a look. Will you apply it? > > Can someone please repost the patch to netdev? I don't have a copy > handy and I'd like to see it tracked properly patchwork too. If it's > in patchwork, it won't get lost. From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Fri, 24 Jul 2009 02:44:02 +0200 Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were: - failing ifconfig for IrLAN, resulting in SIOCSIFFLAGS: Cannot assign requested address - irattach working for IrCOMM, but the port stayed disabled Moreover this patch corrects missing sysfs device link. Signed-off-by: Marek Vasut --- drivers/net/irda/pxaficp_ir.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c index 4edbdbe..f5b7d83 100644 --- a/drivers/net/irda/pxaficp_ir.c +++ b/drivers/net/irda/pxaficp_ir.c @@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = { .ndo_stop = pxa_irda_stop, .ndo_start_xmit = pxa_irda_hard_xmit, .ndo_do_ioctl = pxa_irda_ioctl, - .ndo_change_mtu = eth_change_mtu, - .ndo_validate_addr = eth_validate_addr, - .ndo_set_mac_address = eth_mac_addr, }; static int pxa_irda_probe(struct platform_device *pdev) @@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev) if (!dev) goto err_mem_3; + SET_NETDEV_DEV(dev, &pdev->dev); si = netdev_priv(dev); si->dev = &pdev->dev; si->pdata = pdev->dev.platform_data;