Patchwork pxaficp-ir - remove incorrect net_device_ops

login
register
mail settings
Submitter Alexander Beregalov
Date Aug. 24, 2009, 4:38 a.m.
Message ID <20090824043831.GA2473@orion>
Download mbox | patch
Permalink /patch/31891/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alexander Beregalov - Aug. 24, 2009, 4:38 a.m.
On Sun, Aug 23, 2009 at 06:49:24PM -0700, David Miller wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Date: Sun, 23 Aug 2009 21:55:45 +0400
> 
> > David, please have a look. Will you apply it?
> 
> Can someone please repost the patch to netdev?  I don't have a copy
> handy and I'd like to see it tracked properly patchwork too.  If it's
> in patchwork, it won't get lost.

From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 24 Jul 2009 02:44:02 +0200
Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops

This patch fixes broken pxaficp-ir. The problem was in incorrect
net_device_ops being specified which prevented the driver from
operating. The symptoms were:
 - failing ifconfig for IrLAN, resulting in
	SIOCSIFFLAGS: Cannot assign requested address
 - irattach working for IrCOMM, but the port stayed disabled

Moreover this patch corrects missing sysfs device link.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 drivers/net/irda/pxaficp_ir.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
David Miller - Aug. 24, 2009, 5:57 a.m.
From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Mon, 24 Aug 2009 08:38:31 +0400

> Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops
> 
> This patch fixes broken pxaficp-ir. The problem was in incorrect
> net_device_ops being specified which prevented the driver from
> operating. The symptoms were:
>  - failing ifconfig for IrLAN, resulting in
> 	SIOCSIFFLAGS: Cannot assign requested address
>  - irattach working for IrCOMM, but the port stayed disabled
> 
> Moreover this patch corrects missing sysfs device link.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marek Vasut - Aug. 24, 2009, 12:47 p.m.
Dne Po 24. srpna 2009 07:57:43 David Miller napsal(a):
> From: Alexander Beregalov <a.beregalov@gmail.com>
> Date: Mon, 24 Aug 2009 08:38:31 +0400
>
> > Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops
> >
> > This patch fixes broken pxaficp-ir. The problem was in incorrect
> > net_device_ops being specified which prevented the driver from
> > operating. The symptoms were:
> >  - failing ifconfig for IrLAN, resulting in
> > 	SIOCSIFFLAGS: Cannot assign requested address
> >  - irattach working for IrCOMM, but the port stayed disabled
> >
> > Moreover this patch corrects missing sysfs device link.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Applied, thanks.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c
index 4edbdbe..f5b7d83 100644
--- a/drivers/net/irda/pxaficp_ir.c
+++ b/drivers/net/irda/pxaficp_ir.c
@@ -820,9 +820,6 @@  static const struct net_device_ops pxa_irda_netdev_ops = {
 	.ndo_stop		= pxa_irda_stop,
 	.ndo_start_xmit		= pxa_irda_hard_xmit,
 	.ndo_do_ioctl		= pxa_irda_ioctl,
-	.ndo_change_mtu		= eth_change_mtu,
-	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_set_mac_address	= eth_mac_addr,
 };
 
 static int pxa_irda_probe(struct platform_device *pdev)
@@ -847,6 +844,7 @@  static int pxa_irda_probe(struct platform_device *pdev)
 	if (!dev)
 		goto err_mem_3;
 
+	SET_NETDEV_DEV(dev, &pdev->dev);
 	si = netdev_priv(dev);
 	si->dev = &pdev->dev;
 	si->pdata = pdev->dev.platform_data;