| Message ID | 1392028185-4528-1-git-send-email-Ying.Liu@freescale.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: > This patch removes an unnecessary local variable defined > in the function imx_drm_driver_unload() so as to fix the > following build warning. > > drivers/staging/imx-drm/imx-drm-core.c: \ > In function ‘imx_drm_driver_unload’: > drivers/staging/imx-drm/imx-drm-core.c:87:25: \ > warning: unused variable ‘imxdrm’ [-Wunused-variable] Already-Naked-by: me. This is required by later patches in the series posted earlier.
On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote: > On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: >> This patch removes an unnecessary local variable defined >> in the function imx_drm_driver_unload() so as to fix the >> following build warning. >> >> drivers/staging/imx-drm/imx-drm-core.c: \ >> In function ‘imx_drm_driver_unload’: >> drivers/staging/imx-drm/imx-drm-core.c:87:25: \ >> warning: unused variable ‘imxdrm’ [-Wunused-variable] > > Already-Naked-by: me. This is required by later patches in the series > posted earlier. > Sorry. Did you mean that you have already got a fix for this?
On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote: > On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote: > > On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: > >> This patch removes an unnecessary local variable defined > >> in the function imx_drm_driver_unload() so as to fix the > >> following build warning. > >> > >> drivers/staging/imx-drm/imx-drm-core.c: \ > >> In function ‘imx_drm_driver_unload’: > >> drivers/staging/imx-drm/imx-drm-core.c:87:25: \ > >> warning: unused variable ‘imxdrm’ [-Wunused-variable] > > > > Already-Naked-by: me. This is required by later patches in the series > > posted earlier. > > > > Sorry. Did you mean that you have already got a fix for this? No, I mean patches which come after the three which Greg has recently merged - one of which removes users of the above variable - reintroduce users of this variable, so deleting the variable will break those patches. It was also pointless to remove it and then bring it back in the series.
diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 236ed66..573fe88 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -84,8 +84,6 @@ static void imx_drm_driver_lastclose(struct drm_device *drm) static int imx_drm_driver_unload(struct drm_device *drm) { - struct imx_drm_device *imxdrm = drm->dev_private; - imx_drm_device_put(); drm_vblank_cleanup(drm);
This patch removes an unnecessary local variable defined in the function imx_drm_driver_unload() so as to fix the following build warning. drivers/staging/imx-drm/imx-drm-core.c: \ In function ‘imx_drm_driver_unload’: drivers/staging/imx-drm/imx-drm-core.c:87:25: \ warning: unused variable ‘imxdrm’ [-Wunused-variable] Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- drivers/staging/imx-drm/imx-drm-core.c | 2 -- 1 file changed, 2 deletions(-)