diff mbox

[11/17] i2c: i2c-ocores: deprecate class based instantiation

Message ID 1392026654-5343-12-git-send-email-wsa@the-dreams.de
State Accepted
Headers show

Commit Message

Wolfram Sang Feb. 10, 2014, 10:04 a.m. UTC
Warn users that class based instantiation is going away soon in favour
of more robust probing and faster bootup times.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: Peter Korsgaard <jacmet@sunsite.dk>
---

This patch is a suggestion. Looking for an ack by someone who actually uses
the driver.

 drivers/i2c/busses/i2c-ocores.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Feb. 10, 2014, 10:14 a.m. UTC | #1
>>>>> "Wolfram" == Wolfram Sang <wsa@the-dreams.de> writes:

 > Warn users that class based instantiation is going away soon in favour
 > of more robust probing and faster bootup times.

 > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
 > Cc: Peter Korsgaard <jacmet@sunsite.dk>
 > ---

 > This patch is a suggestion. Looking for an ack by someone who actually uses
 > the driver.

It's been some time since I last used it, but I never needed the class
based probing, so:

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index c61f37a..f49fe26 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -247,7 +247,7 @@  static const struct i2c_algorithm ocores_algorithm = {
 static struct i2c_adapter ocores_adapter = {
 	.owner		= THIS_MODULE,
 	.name		= "i2c-ocores",
-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
+	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD | I2C_CLASS_DEPRECATED,
 	.algo		= &ocores_algorithm,
 };