Patchwork Fix useless test: int > INT_MAX

login
register
mail settings
Submitter Nicolas de Pesloüan
Date Aug. 22, 2009, 12:17 p.m.
Message ID <4A8FE1D1.1030506@free.fr>
Download mbox | patch
Permalink /patch/31869/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Nicolas de Pesloüan - Aug. 22, 2009, 12:17 p.m.
max_bonds is of type int and cannot be greater than INT_MAX.

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
---
  drivers/net/bonding/bond_main.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 4798d30..edd71a1 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4755,7 +4755,7 @@  static int bond_check_params(struct bond_params *params)
  		params->ad_select = BOND_AD_STABLE;
  	}

-	if (max_bonds < 0 || max_bonds > INT_MAX) {
+	if (max_bonds < 0) {
  		pr_warning(DRV_NAME
  		       ": Warning: max_bonds (%d) not in range %d-%d, so it "
  		       "was reset to BOND_DEFAULT_MAX_BONDS (%d)\n",