diff mbox

[09/21] fs: Mark function as static in ext3/xattr_security.c

Message ID bcf66d9631e4094a46e539950331f79289e4d85a.1391949868.git.rashika.kheria@gmail.com
State Not Applicable, archived
Headers show

Commit Message

Rashika Kheria Feb. 9, 2014, 1:09 p.m. UTC
Mark function as static in ext3/xattr_security.c because it is not used
outside this file.

This eliminates the following warning in ext3/xattr_security.c:
fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 fs/ext3/xattr_security.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Jan Kara Feb. 11, 2014, 8:49 p.m. UTC | #1
On Sun 09-02-14 18:39:11, Rashika Kheria wrote:
> Mark function as static in ext3/xattr_security.c because it is not used
> outside this file.
> 
> This eliminates the following warning in ext3/xattr_security.c:
> fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
  Thanks. I've merged the patch.

								Honza
> ---
>  fs/ext3/xattr_security.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3387664..722c2bf 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
>  			      name, value, size, flags);
>  }
>  
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> -		    void *fs_info)
> +static int ext3_initxattrs(struct inode *inode,
> +			   const struct xattr *xattr_array,
> +			   void *fs_info)
>  {
>  	const struct xattr *xattr;
>  	handle_t *handle = fs_info;
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3387664..722c2bf 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -43,8 +43,9 @@  ext3_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
-		    void *fs_info)
+static int ext3_initxattrs(struct inode *inode,
+			   const struct xattr *xattr_array,
+			   void *fs_info)
 {
 	const struct xattr *xattr;
 	handle_t *handle = fs_info;