Message ID | 999693f220bb65e2a07c4450548d99ea3ceac9d2.1391949868.git.rashika.kheria@gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Sun 09-02-14 18:36:27, Rashika Kheria wrote: > Mark function as static in ext3/dir.c because it is not used outside > this file. > > This also eliminates the following warning in ext3/dir.c: > fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > Reviewed-by: Josh Triplett <josh@joshtriplett.org> Thanks. I've merged the patch. Honza > --- > fs/ext3/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c > index e66e480..17742ee 100644 > --- a/fs/ext3/dir.c > +++ b/fs/ext3/dir.c > @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp) > * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX) > * will be invalid once the directory was converted into a dx directory > */ > -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) > +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) > { > struct inode *inode = file->f_mapping->host; > int dx_dir = is_dx_dir(inode); > -- > 1.7.9.5 >
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c index e66e480..17742ee 100644 --- a/fs/ext3/dir.c +++ b/fs/ext3/dir.c @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp) * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX) * will be invalid once the directory was converted into a dx directory */ -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence) { struct inode *inode = file->f_mapping->host; int dx_dir = is_dx_dir(inode);