| Message ID | 45e9dd39b342bfb2308b75bd2b539de2c63bd6cb.1391888654.git.rashika.kheria@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Feb 09, 2014 at 01:29:55AM +0530, Rashika Kheria wrote: > Move prototype declaration of functions to header file include/net/dn.h > from net/decnet/af_decnet.c because they are used by more than one file. > > This eliminates the following warning in net/decnet/af_decnet.c: > net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for ‘dn_register_sysctl’ [-Wmissing-prototypes] > net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for ‘dn_unregister_sysctl’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> > include/net/dn.h | 2 ++ > net/decnet/af_decnet.c | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/net/dn.h b/include/net/dn.h > index ccc1558..913b73d 100644 > --- a/include/net/dn.h > +++ b/include/net/dn.h > @@ -200,6 +200,8 @@ static inline void dn_sk_ports_copy(struct flowidn *fld, struct dn_scp *scp) > } > > unsigned int dn_mss_from_pmtu(struct net_device *dev, int mtu); > +void dn_register_sysctl(void); > +void dn_unregister_sysctl(void); > > #define DN_MENUVER_ACC 0x01 > #define DN_MENUVER_USR 0x02 > diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c > index 24d9193..4c04848 100644 > --- a/net/decnet/af_decnet.c > +++ b/net/decnet/af_decnet.c > @@ -2351,9 +2351,6 @@ static const struct proto_ops dn_proto_ops = { > .sendpage = sock_no_sendpage, > }; > > -void dn_register_sysctl(void); > -void dn_unregister_sysctl(void); > - > MODULE_DESCRIPTION("The Linux DECnet Network Protocol"); > MODULE_AUTHOR("Linux DECnet Project Team"); > MODULE_LICENSE("GPL"); > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/dn.h b/include/net/dn.h index ccc1558..913b73d 100644 --- a/include/net/dn.h +++ b/include/net/dn.h @@ -200,6 +200,8 @@ static inline void dn_sk_ports_copy(struct flowidn *fld, struct dn_scp *scp) } unsigned int dn_mss_from_pmtu(struct net_device *dev, int mtu); +void dn_register_sysctl(void); +void dn_unregister_sysctl(void); #define DN_MENUVER_ACC 0x01 #define DN_MENUVER_USR 0x02 diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index 24d9193..4c04848 100644 --- a/net/decnet/af_decnet.c +++ b/net/decnet/af_decnet.c @@ -2351,9 +2351,6 @@ static const struct proto_ops dn_proto_ops = { .sendpage = sock_no_sendpage, }; -void dn_register_sysctl(void); -void dn_unregister_sysctl(void); - MODULE_DESCRIPTION("The Linux DECnet Network Protocol"); MODULE_AUTHOR("Linux DECnet Project Team"); MODULE_LICENSE("GPL");
Move prototype declaration of functions to header file include/net/dn.h from net/decnet/af_decnet.c because they are used by more than one file. This eliminates the following warning in net/decnet/af_decnet.c: net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for ‘dn_register_sysctl’ [-Wmissing-prototypes] net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for ‘dn_unregister_sysctl’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> --- include/net/dn.h | 2 ++ net/decnet/af_decnet.c | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-)