mbox

[GIT,PULL] clk: mvebu: fixes for v3.14

Message ID 20140208173154.GL8533@titan.lakedaemon.net
State New
Headers show

Pull-request

git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14

Message

Jason Cooper Feb. 8, 2014, 5:31 p.m. UTC
Mike,

Here's a round of fixes I've had in -next for several days.  It's not
the ideal solution, but a short term one while we hash out a proper
solution for v3.15+.

thx,

Jason.

The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:

  Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)

are available in the git repository at:

  git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14

for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:

  clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)

----------------------------------------------------------------
mvebu clock fixes for v3.14

 - kirkwood, dove, armada-xp, armada-370
    - force clock init order broken by sorting DT ocp nodes by address
    - fixes boot failures on affected platforms

----------------------------------------------------------------
Sebastian Hesselbarth (4):
      clk: mvebu: armada-370: maintain clock init order
      clk: mvebu: armada-xp: maintain clock init order
      clk: mvebu: dove: maintain clock init order
      clk: mvebu: kirkwood: maintain clock init order

 drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
 drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
 drivers/clk/mvebu/dove.c       | 19 +++++++++----------
 drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
 4 files changed, 44 insertions(+), 50 deletions(-)

Comments

Jason Cooper Feb. 18, 2014, 7:28 p.m. UTC | #1
Mike,

On Sat, Feb 08, 2014 at 12:31:54PM -0500, Jason Cooper wrote:
> Mike,
> 
> Here's a round of fixes I've had in -next for several days.  It's not
> the ideal solution, but a short term one while we hash out a proper
> solution for v3.15+.

Ping?  just didn't want this to fall off of your plate.

thx,

Jason.

> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
> 
>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
> 
> are available in the git repository at:
> 
>   git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14
> 
> for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:
> 
>   clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)
> 
> ----------------------------------------------------------------
> mvebu clock fixes for v3.14
> 
>  - kirkwood, dove, armada-xp, armada-370
>     - force clock init order broken by sorting DT ocp nodes by address
>     - fixes boot failures on affected platforms
> 
> ----------------------------------------------------------------
> Sebastian Hesselbarth (4):
>       clk: mvebu: armada-370: maintain clock init order
>       clk: mvebu: armada-xp: maintain clock init order
>       clk: mvebu: dove: maintain clock init order
>       clk: mvebu: kirkwood: maintain clock init order
> 
>  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
>  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
>  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
>  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
>  4 files changed, 44 insertions(+), 50 deletions(-)
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Mike Turquette Feb. 19, 2014, 5:42 a.m. UTC | #2
Quoting Jason Cooper (2014-02-08 09:31:54)
> Mike,
> 
> Here's a round of fixes I've had in -next for several days.  It's not
> the ideal solution, but a short term one while we hash out a proper
> solution for v3.15+.

Taken into clk-fixes.

Thanks!
Mike

> 
> thx,
> 
> Jason.
> 
> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
> 
>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
> 
> are available in the git repository at:
> 
>   git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14
> 
> for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:
> 
>   clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)
> 
> ----------------------------------------------------------------
> mvebu clock fixes for v3.14
> 
>  - kirkwood, dove, armada-xp, armada-370
>     - force clock init order broken by sorting DT ocp nodes by address
>     - fixes boot failures on affected platforms
> 
> ----------------------------------------------------------------
> Sebastian Hesselbarth (4):
>       clk: mvebu: armada-370: maintain clock init order
>       clk: mvebu: armada-xp: maintain clock init order
>       clk: mvebu: dove: maintain clock init order
>       clk: mvebu: kirkwood: maintain clock init order
> 
>  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
>  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
>  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
>  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
>  4 files changed, 44 insertions(+), 50 deletions(-)
Gregory CLEMENT Feb. 19, 2014, 10:20 a.m. UTC | #3
On 19/02/2014 06:42, Mike Turquette wrote:
> Quoting Jason Cooper (2014-02-08 09:31:54)
>> Mike,
>>
>> Here's a round of fixes I've had in -next for several days.  It's not
>> the ideal solution, but a short term one while we hash out a proper
>> solution for v3.15+.
> 
> Taken into clk-fixes.

Hi Mike,

we will have the same kind of issue with Armada 375 and Armada38x.
Are you going to take the patch "clk: respect the clock dependencies
in of_clk_init"
See the V2 here http://www.spinics.net/lists/arm-kernel/msg306442.html

My intent is not to put a pressure on you to take this patch, but as
I explained Armada 375 and Armada38x will be in the same situation of
the other mvebu were. The patch I mentioned is a solution to fix it
and if it won't be merged, than we need an other solution. This alternate
solution is easy to find, it will be the same as this patch set.


Thanks,

Gregory



> 
> Thanks!
> Mike
> 
>>
>> thx,
>>
>> Jason.
>>
>> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
>>
>>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
>>
>> are available in the git repository at:
>>
>>   git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14
>>
>> for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:
>>
>>   clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)
>>
>> ----------------------------------------------------------------
>> mvebu clock fixes for v3.14
>>
>>  - kirkwood, dove, armada-xp, armada-370
>>     - force clock init order broken by sorting DT ocp nodes by address
>>     - fixes boot failures on affected platforms
>>
>> ----------------------------------------------------------------
>> Sebastian Hesselbarth (4):
>>       clk: mvebu: armada-370: maintain clock init order
>>       clk: mvebu: armada-xp: maintain clock init order
>>       clk: mvebu: dove: maintain clock init order
>>       clk: mvebu: kirkwood: maintain clock init order
>>
>>  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
>>  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
>>  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
>>  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
>>  4 files changed, 44 insertions(+), 50 deletions(-)
Mike Turquette Feb. 23, 2014, 11:04 p.m. UTC | #4
Quoting Gregory CLEMENT (2014-02-19 02:20:21)
> On 19/02/2014 06:42, Mike Turquette wrote:
> > Quoting Jason Cooper (2014-02-08 09:31:54)
> >> Mike,
> >>
> >> Here's a round of fixes I've had in -next for several days.  It's not
> >> the ideal solution, but a short term one while we hash out a proper
> >> solution for v3.15+.
> > 
> > Taken into clk-fixes.
> 
> Hi Mike,
> 
> we will have the same kind of issue with Armada 375 and Armada38x.
> Are you going to take the patch "clk: respect the clock dependencies
> in of_clk_init"
> See the V2 here http://www.spinics.net/lists/arm-kernel/msg306442.html
> 
> My intent is not to put a pressure on you to take this patch, but as
> I explained Armada 375 and Armada38x will be in the same situation of
> the other mvebu were. The patch I mentioned is a solution to fix it
> and if it won't be merged, than we need an other solution. This alternate
> solution is easy to find, it will be the same as this patch set.

Hi Gregory,

The clock dependencies patch is not without controversy. I've looked
through V2 and it looks OK, but I need to think on it a bit more. I'll
make a call later this week, so you'll know what to do for Armada.

Either way I won't take that patch in as a fix for the current -rc's. It
will land in 3.15.

Regards,
Mike

> 
> 
> Thanks,
> 
> Gregory
> 
> 
> 
> > 
> > Thanks!
> > Mike
> > 
> >>
> >> thx,
> >>
> >> Jason.
> >>
> >> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
> >>
> >>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14
> >>
> >> for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:
> >>
> >>   clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)
> >>
> >> ----------------------------------------------------------------
> >> mvebu clock fixes for v3.14
> >>
> >>  - kirkwood, dove, armada-xp, armada-370
> >>     - force clock init order broken by sorting DT ocp nodes by address
> >>     - fixes boot failures on affected platforms
> >>
> >> ----------------------------------------------------------------
> >> Sebastian Hesselbarth (4):
> >>       clk: mvebu: armada-370: maintain clock init order
> >>       clk: mvebu: armada-xp: maintain clock init order
> >>       clk: mvebu: dove: maintain clock init order
> >>       clk: mvebu: kirkwood: maintain clock init order
> >>
> >>  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
> >>  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
> >>  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
> >>  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
> >>  4 files changed, 44 insertions(+), 50 deletions(-)
> 
> 
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Gregory CLEMENT Feb. 24, 2014, 9:06 a.m. UTC | #5
On 24/02/2014 00:04, Mike Turquette wrote:
> Quoting Gregory CLEMENT (2014-02-19 02:20:21)
>> On 19/02/2014 06:42, Mike Turquette wrote:
>>> Quoting Jason Cooper (2014-02-08 09:31:54)
>>>> Mike,
>>>>
>>>> Here's a round of fixes I've had in -next for several days.  It's not
>>>> the ideal solution, but a short term one while we hash out a proper
>>>> solution for v3.15+.
>>>
>>> Taken into clk-fixes.
>>
>> Hi Mike,
>>
>> we will have the same kind of issue with Armada 375 and Armada38x.
>> Are you going to take the patch "clk: respect the clock dependencies
>> in of_clk_init"
>> See the V2 here http://www.spinics.net/lists/arm-kernel/msg306442.html
>>
>> My intent is not to put a pressure on you to take this patch, but as
>> I explained Armada 375 and Armada38x will be in the same situation of
>> the other mvebu were. The patch I mentioned is a solution to fix it
>> and if it won't be merged, than we need an other solution. This alternate
>> solution is easy to find, it will be the same as this patch set.
> 
Hi Mike,



> Hi Gregory,
> 
> The clock dependencies patch is not without controversy. I've looked

I know, that's why I waited for your opinion.

> through V2 and it looks OK, but I need to think on it a bit more. I'll
> make a call later this week, so you'll know what to do for Armada.
> 
> Either way I won't take that patch in as a fix for the current -rc's. It
> will land in 3.15.

Yes of course, for 3.14 Sebastian's patch set fixes the issue we had. The
clocks driver for Armada 375 and Armada 38x, which will have this issue,
are planed to be merged in 3.15 so it will be ok.

Thanks,

Gregory


> 
> Regards,
> Mike
> 
>>
>>
>> Thanks,
>>
>> Gregory
>>
>>
>>
>>>
>>> Thanks!
>>> Mike
>>>
>>>>
>>>> thx,
>>>>
>>>> Jason.
>>>>
>>>> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
>>>>
>>>>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   git://git.infradead.org/linux-mvebu.git tags/mvebu-clk-fixes-3.14
>>>>
>>>> for you to fetch changes up to 58d516ae95cbf7eed44f85a01cdfad41f17b4197:
>>>>
>>>>   clk: mvebu: kirkwood: maintain clock init order (2014-02-06 18:07:01 +0000)
>>>>
>>>> ----------------------------------------------------------------
>>>> mvebu clock fixes for v3.14
>>>>
>>>>  - kirkwood, dove, armada-xp, armada-370
>>>>     - force clock init order broken by sorting DT ocp nodes by address
>>>>     - fixes boot failures on affected platforms
>>>>
>>>> ----------------------------------------------------------------
>>>> Sebastian Hesselbarth (4):
>>>>       clk: mvebu: armada-370: maintain clock init order
>>>>       clk: mvebu: armada-xp: maintain clock init order
>>>>       clk: mvebu: dove: maintain clock init order
>>>>       clk: mvebu: kirkwood: maintain clock init order
>>>>
>>>>  drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
>>>>  drivers/clk/mvebu/armada-xp.c  | 20 +++++++++-----------
>>>>  drivers/clk/mvebu/dove.c       | 19 +++++++++----------
>>>>  drivers/clk/mvebu/kirkwood.c   | 34 ++++++++++++++++------------------
>>>>  4 files changed, 44 insertions(+), 50 deletions(-)
>>
>>
>> -- 
>> Gregory Clement, Free Electrons
>> Kernel, drivers, real-time and embedded Linux
>> development, consulting, training and support.
>> http://free-electrons.com