Message ID | CAKxPW671KgBCJoYnRHiDj5fccqEhB6X0pEq48gjvJxnT_Fb-Rw@mail.gmail.com |
---|---|
State | New |
Headers | show |
Hi! On Wed, 5 Feb 2014 16:33:19 -0800, Sharad Singhai <singhai@google.com> wrote: > I am really sorry about the delay. No worries; not exactly a severe issue. ;-) > I couldn't exactly reproduce the > warning which you described Maybe the version of makeinfo is relevant? $ makeinfo --version | head -n 1 makeinfo (GNU texinfo) 5.1 > but I found a place where two nodes were > out of order in optinfo.texi. Could you please apply the following > patch and see if the problem goes away? If it works for you, I will > commit the doc fixes. > > Also I would appreciate the exact command which produces these warnings. Your patch does fix the problem; see the following diff of the build log, where the warnings are now gone, and which also happens to contain the makeinfo command line. @@ -4199,12 +4199,6 @@ if [ xinfo = xinfo ]; then \ makeinfo --split-size=5000000 --split-size=5000000 --no-split -I . -I ../../source/gcc/doc \ -I ../../source/gcc/doc/include -o doc/gccint.info ../../source/gcc/doc/gccint.texi; \ fi -../../source/gcc/doc/optinfo.texi:45: warning: node next `Optimization groups' in menu `Dump output verbosity' and in sectioning `Dump files and streams' differ -../../source/gcc/doc/optinfo.texi:77: warning: node next `Dump files and streams' in menu `Dump types' and in sectioning `Dump output verbosity' differ -../../source/gcc/doc/optinfo.texi:77: warning: node prev `Dump files and streams' in menu `Dump output verbosity' and in sectioning `Optimization groups' differ -../../source/gcc/doc/optinfo.texi:104: warning: node next `Dump output verbosity' in menu `Dump files and streams' and in sectioning `Dump types' differ -../../source/gcc/doc/optinfo.texi:104: warning: node prev `Dump output verbosity' in menu `Optimization groups' and in sectioning `Dump files and streams' differ -../../source/gcc/doc/optinfo.texi:137: warning: node prev `Dump types' in menu `Dump files and streams' and in sectioning `Dump output verbosity' differ if [ xinfo = xinfo ]; then \ makeinfo --split-size=5000000 --split-size=5000000 --no-split -I ../../source/gcc/doc \ -I ../../source/gcc/doc/include -o doc/gccinstall.info ../../source/gcc/doc/install.texi; \ > * doc/optinfo.texi: Fix order of nodes. Thanks, please commit. Grüße, Thomas
Committed as r207767. Indeed, I had an older version of makeinfo. Once I updated to the latest version 5.2, I saw the warnings. Those are fixed by this patch. Thanks, Sharad > On Tue, Feb 11, 2014 at 11:42 PM, Thomas Schwinge <thomas@codesourcery.com> > wrote: >> >> Hi! >> >> On Wed, 5 Feb 2014 16:33:19 -0800, Sharad Singhai <singhai@google.com> >> wrote: >> > I am really sorry about the delay. >> >> No worries; not exactly a severe issue. ;-) >> >> > I couldn't exactly reproduce the >> > warning which you described >> >> Maybe the version of makeinfo is relevant? >> >> $ makeinfo --version | head -n 1 >> makeinfo (GNU texinfo) 5.1 >> >> > but I found a place where two nodes were >> > out of order in optinfo.texi. Could you please apply the following >> > patch and see if the problem goes away? If it works for you, I will >> > commit the doc fixes. >> > >> > Also I would appreciate the exact command which produces these warnings. >> >> Your patch does fix the problem; see the following diff of the build log, >> where the warnings are now gone, and which also happens to contain the >> makeinfo command line. >> >> @@ -4199,12 +4199,6 @@ if [ xinfo = xinfo ]; then \ >> makeinfo --split-size=5000000 --split-size=5000000 >> --no-split -I . -I ../../source/gcc/doc \ >> -I ../../source/gcc/doc/include -o doc/gccint.info >> ../../source/gcc/doc/gccint.texi; \ >> fi >> -../../source/gcc/doc/optinfo.texi:45: warning: node next `Optimization >> groups' in menu `Dump output verbosity' and in sectioning `Dump files and >> streams' differ >> -../../source/gcc/doc/optinfo.texi:77: warning: node next `Dump files and >> streams' in menu `Dump types' and in sectioning `Dump output verbosity' >> differ >> -../../source/gcc/doc/optinfo.texi:77: warning: node prev `Dump files and >> streams' in menu `Dump output verbosity' and in sectioning `Optimization >> groups' differ >> -../../source/gcc/doc/optinfo.texi:104: warning: node next `Dump output >> verbosity' in menu `Dump files and streams' and in sectioning `Dump types' >> differ >> -../../source/gcc/doc/optinfo.texi:104: warning: node prev `Dump output >> verbosity' in menu `Optimization groups' and in sectioning `Dump files and >> streams' differ >> -../../source/gcc/doc/optinfo.texi:137: warning: node prev `Dump types' in >> menu `Dump files and streams' and in sectioning `Dump output verbosity' >> differ >> if [ xinfo = xinfo ]; then \ >> makeinfo --split-size=5000000 --split-size=5000000 >> --no-split -I ../../source/gcc/doc \ >> -I ../../source/gcc/doc/include -o >> doc/gccinstall.info ../../source/gcc/doc/install.texi; \ >> >> > * doc/optinfo.texi: Fix order of nodes. >> >> Thanks, please commit. >> >> >> Grüße, >> Thomas > >
Index: doc/optinfo.texi =================================================================== --- doc/optinfo.texi (revision 207525) +++ doc/optinfo.texi (working copy) @@ -12,8 +12,8 @@ information about various compiler transformations @menu * Dump setup:: Setup of optimization dumps. * Optimization groups:: Groups made up of optimization passes. +* Dump files and streams:: Dump output file names and streams. * Dump output verbosity:: How much information to dump. -* Dump files and streams:: Dump output file names and streams. * Dump types:: Various types of dump functions. * Dump examples:: Sample usage. @end menu