| Message ID | 1391583561-25399-1-git-send-email-jesse@nicira.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jesse Gross <jesse@nicira.com> Date: Tue, 4 Feb 2014 22:59:16 -0800 > A handful of bug fixes for net/3.14. High level fixes are: > * Regressions introduced by the zerocopy changes, particularly with > old userspaces. > * A few bugs lingering from the introduction of megaflows. > * Overly zealous error checking that is now being triggered frequently > in common cases. Pulled, thanks Jesse. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 5, 2014 at 8:59 AM, Jesse Gross <jesse@nicira.com> wrote: > > A handful of bug fixes for net/3.14. High level fixes are: > * Regressions introduced by the zerocopy changes, particularly with > old userspaces. Hi, so this post was the 2nd version of the five patches you posted earlier, right? it would be very helpful if you denote that on the subject line (e.g just use --subject-prefix="PATCH net V1" for git format-patch) and provide crash diff listing from V0. Also, on a related note to the patch that deals with locking, I see these two smatch complaints, which might be false-positives, what's your thinking? net/openvswitch/flow.c:127 ovs_flow_stats_get() warn: returning with unbalanced local_bh_disable net/openvswitch/flow.c:160 ovs_flow_stats_clear() warn: returning with unbalanced local_bh_disable -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 5, 2014 at 11:09 PM, Or Gerlitz <or.gerlitz@gmail.com> wrote: > On Wed, Feb 5, 2014 at 8:59 AM, Jesse Gross <jesse@nicira.com> wrote: >> >> A handful of bug fixes for net/3.14. High level fixes are: >> * Regressions introduced by the zerocopy changes, particularly with >> old userspaces. > > Hi, so this post was the 2nd version of the five patches you posted > earlier, right? it would be very helpful if you > denote that on the subject line (e.g just use --subject-prefix="PATCH > net V1" for git format-patch) and provide > crash diff listing from V0. Also, on a related note to the patch that > deals with locking, I see these two smatch > complaints, which might be false-positives, what's your thinking? > > net/openvswitch/flow.c:127 ovs_flow_stats_get() warn: returning with > unbalanced local_bh_disable > net/openvswitch/flow.c:160 ovs_flow_stats_clear() warn: returning with > unbalanced local_bh_disable Yes, it looks like a false positive to me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
A handful of bug fixes for net/3.14. High level fixes are: * Regressions introduced by the zerocopy changes, particularly with old userspaces. * A few bugs lingering from the introduction of megaflows. * Overly zealous error checking that is now being triggered frequently in common cases. The following changes since commit bce3ea81d5b2a33ed0e275d58a45f10ce95cbd50: xen-netfront: handle backend CLOSED without CLOSING (2014-02-04 20:42:36 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch.git fixes for you to fetch changes up to c14e0953ca51dbcb8d1ac92acbdcff23d0caa158: openvswitch: Suppress error messages on megaflow updates (2014-02-04 22:32:38 -0800) ---------------------------------------------------------------- Andy Zhou (2): openvswitch: Fix kernel panic on ovs_flow_free openvswitch: Suppress error messages on megaflow updates Daniele Di Proietto (1): openvswitch: Fix ovs_dp_cmd_msg_size() Pravin B Shelar (1): openvswitch: Fix ovs_flow_free() ovs-lock assert. Thomas Graf (1): openvswitch: Pad OVS_PACKET_ATTR_PACKET if linear copy was performed net/openvswitch/datapath.c | 23 ++++++++---- net/openvswitch/flow_table.c | 88 ++++++++++++++++++++++---------------------- net/openvswitch/flow_table.h | 2 +- 3 files changed, 60 insertions(+), 53 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html