Patchwork [07/29] monitor: Setup a QDict with arguments to handlers

login
register
mail settings
Submitter Luiz Capitulino
Date Aug. 19, 2009, 11:07 p.m.
Message ID <1250723280-3509-8-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/31680/
State Superseded
Headers show

Comments

Luiz Capitulino - Aug. 19, 2009, 11:07 p.m.
With this commit monitor_handle_command() will be able to setup a
QDict with arguments to command handlers.

However, the current 'args[]' method is still being used, next
changes will port commands to get their arguments from the dictionary.

Two changes are worth noting:

1. The '/' argument type always adds the following standard keys in the
dictionary: 'count', 'format' and 'size'. This way, the argument
name used in the 'args_type' string doesn't matter

2. The optional argument type '?' doesn't need to pass the additional
'has_arg' argument, hanlders can do the same check with qdict_exists()

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
Markus Armbruster - Aug. 24, 2009, 4:25 p.m.
Luiz Capitulino <lcapitulino@redhat.com> writes:

> With this commit monitor_handle_command() will be able to setup a
> QDict with arguments to command handlers.
>
> However, the current 'args[]' method is still being used, next
> changes will port commands to get their arguments from the dictionary.
>
> Two changes are worth noting:
>
> 1. The '/' argument type always adds the following standard keys in the
> dictionary: 'count', 'format' and 'size'. This way, the argument
> name used in the 'args_type' string doesn't matter

Can have at most one '/' argument then.  Hmm.  Document as restriction?

> 2. The optional argument type '?' doesn't need to pass the additional
> 'has_arg' argument, hanlders can do the same check with qdict_exists()
Luiz Capitulino - Aug. 24, 2009, 5:07 p.m.
On Mon, 24 Aug 2009 18:25:37 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > With this commit monitor_handle_command() will be able to setup a
> > QDict with arguments to command handlers.
> >
> > However, the current 'args[]' method is still being used, next
> > changes will port commands to get their arguments from the dictionary.
> >
> > Two changes are worth noting:
> >
> > 1. The '/' argument type always adds the following standard keys in the
> > dictionary: 'count', 'format' and 'size'. This way, the argument
> > name used in the 'args_type' string doesn't matter
> 
> Can have at most one '/' argument then.  Hmm.  Document as restriction?

 Yes. There are ways to fix this if needed, but no handler uses more
than one and I don't see a use case for this either.

> 
> > 2. The optional argument type '?' doesn't need to pass the additional
> > 'has_arg' argument, hanlders can do the same check with qdict_exists()

Patch

diff --git a/monitor.c b/monitor.c
index 89b9467..d3b62e3 100644
--- a/monitor.c
+++ b/monitor.c
@@ -44,6 +44,9 @@ 
 #include "migration.h"
 #include "kvm.h"
 #include "acl.h"
+#include "qint.h"
+#include "qdict.h"
+#include "qstring.h"
 
 //#define DEBUG
 //#define DEBUG_COMPLETION
@@ -2595,6 +2598,7 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
     char cmdname[256];
     char buf[1024];
     char *key;
+    QDict *qdict;
     void *str_allocated[MAX_ARGS];
     void *args[MAX_ARGS];
     void (*handler_0)(Monitor *mon);
@@ -2639,6 +2643,8 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
         return;
     }
 
+    qdict = qdict_new();
+
     for(i = 0; i < MAX_ARGS; i++)
         str_allocated[i] = NULL;
 
@@ -2696,6 +2702,8 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                     goto fail;
                 }
                 args[nb_args++] = str;
+                if (str)
+                    qdict_add_qstring(qdict, key, qstring_from_str(str));
             }
             break;
         case '/':
@@ -2777,12 +2785,16 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                 args[nb_args++] = (void*)(long)count;
                 args[nb_args++] = (void*)(long)format;
                 args[nb_args++] = (void*)(long)size;
+                qdict_add_qint(qdict, "count", qint_from_int(count));
+                qdict_add_qint(qdict, "format", qint_from_int(format));
+                qdict_add_qint(qdict, "size", qint_from_int(size));
             }
             break;
         case 'i':
         case 'l':
             {
                 int64_t val;
+                int dict_add = 1;
 
                 while (qemu_isspace(*p))
                     p++;
@@ -2805,6 +2817,7 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                     typestr++;
                     if (nb_args >= MAX_ARGS)
                         goto error_args;
+                    dict_add = has_arg;
                     args[nb_args++] = (void *)(long)has_arg;
                     if (!has_arg) {
                         if (nb_args >= MAX_ARGS)
@@ -2820,6 +2833,8 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                     if (nb_args >= MAX_ARGS)
                         goto error_args;
                     args[nb_args++] = (void *)(long)val;
+                    if (dict_add)
+                        qdict_add_qint(qdict, key, qint_from_int64(val));
                 } else {
                     if ((nb_args + 1) >= MAX_ARGS)
                         goto error_args;
@@ -2829,6 +2844,7 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                     args[nb_args++] = (void *)0;
 #endif
                     args[nb_args++] = (void *)(long)(val & 0xffffffff);
+                    qdict_add_qint(qdict, key, qint_from_int64(val));
                 }
             }
             break;
@@ -2856,6 +2872,7 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
                 if (nb_args >= MAX_ARGS)
                     goto error_args;
                 args[nb_args++] = (void *)(long)has_option;
+                qdict_add_qint(qdict, key, qint_from_int(has_option));
             }
             break;
         default:
@@ -2932,6 +2949,7 @@  static void monitor_handle_command(Monitor *mon, const char *cmdline)
     qemu_free(key);
     for(i = 0; i < MAX_ARGS; i++)
         qemu_free(str_allocated[i]);
+    QDECREF(qdict);
 }
 
 static void cmd_completion(const char *name, const char *list)