Patchwork [1/1] dependencies.sh: stop stray a.out being created for ia32 compiler test

login
register
mail settings
Submitter Martin Bark
Date Feb. 4, 2014, 10:10 p.m.
Message ID <1391551823-1216-1-git-send-email-martin@barkynet.com>
Download mbox | patch
Permalink /patch/316771/
State Accepted
Commit 2e8dd9563dbb39b74b0c628295a671ab81e6182b
Headers show

Comments

Martin Bark - Feb. 4, 2014, 10:10 p.m.
If the grub package is selected it also selects
BR2_HOSTARCH_NEEDS_IA32_COMPILER.  This triggers a test in dependencies.sh
to verify the host compiler can build 32 bit executables.  Currently this
test does not set any output for the compiler which causes a stray a.out
to be create outside the output directory.  This patch sets the compiler
output to /dev/null so no a.out is created but the test is still performed.

Signed-off-by: Martin Bark <martin@barkynet.com>
---
 support/dependencies/dependencies.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Korsgaard - Feb. 5, 2014, 10:58 p.m.
>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

 > If the grub package is selected it also selects
 > BR2_HOSTARCH_NEEDS_IA32_COMPILER.  This triggers a test in dependencies.sh
 > to verify the host compiler can build 32 bit executables.  Currently this
 > test does not set any output for the compiler which causes a stray a.out
 > to be create outside the output directory.  This patch sets the compiler
 > output to /dev/null so no a.out is created but the test is still performed.

 > Signed-off-by: Martin Bark <martin@barkynet.com>

Committed, thanks.

Patch

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 47d4d10..0e22ba0 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -207,7 +207,7 @@  if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BUILDROOT_CONFIG ; then
 fi
 
 if grep -q ^BR2_HOSTARCH_NEEDS_IA32_COMPILER=y $BUILDROOT_CONFIG ; then
-    if ! echo "int main(void) {}" | gcc -m32 -x c - ; then
+    if ! echo "int main(void) {}" | gcc -m32 -x c - -o /dev/null ; then
 	echo
 	echo "Your Buildroot configuration needs a compiler capable of building 32 bits binaries."
 	echo "If you're running a Debian/Ubuntu distribution, install the gcc-multilib package."