diff mbox

[net-next] tipc: explicitly include core.h in addr.h

Message ID 1391525361-31839-1-git-send-email-andreas.bofjall@ericsson.com
State Deferred, archived
Delegated to: David Miller
Headers show

Commit Message

Andreas Bofjäll Feb. 4, 2014, 2:49 p.m. UTC 
From: Andreas Bofjäll <andreas.bofjall@ericsson.com>

The inline functions in addr.h uses tipc_own_addr which is exported by
core.h, but addr.h never actually includes it. It works because it is
explicitly included where this is used, but it looks a bit strange.

Include core.h in addr.h explicitly to make the dependency clearer.

Signed-off-by: Andreas Bofjäll <andreas.bofjall@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
---
 net/tipc/addr.h |    2 ++
 1 file changed, 2 insertions(+)

Comments

David Miller Feb. 5, 2014, 4:33 a.m. UTC | #1 
From: <andreas.bofjall@ericsson.com>
Date: Tue, 4 Feb 2014 15:49:21 +0100

> From: Andreas Bofjäll <andreas.bofjall@ericsson.com>
> 
> The inline functions in addr.h uses tipc_own_addr which is exported by
> core.h, but addr.h never actually includes it. It works because it is
> explicitly included where this is used, but it looks a bit strange.
> 
> Include core.h in addr.h explicitly to make the dependency clearer.
> 
> Signed-off-by: Andreas Bofjäll <andreas.bofjall@ericsson.com>
> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>

The net-next tree is not open at this time.  Please resubmit this
when the net-next tree opens back up.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/tipc/addr.h b/net/tipc/addr.h
index 60b00ab..a74acf9 100644
--- a/net/tipc/addr.h
+++ b/net/tipc/addr.h
@@ -37,6 +37,8 @@ 
 #ifndef _TIPC_ADDR_H
 #define _TIPC_ADDR_H
 
+#include "core.h"
+
 #define TIPC_ZONE_MASK		0xff000000u
 #define TIPC_CLUSTER_MASK	0xfffff000u