| Message ID | eb9c6c476786ff901512e46859f0d59a5e62170d.1391512266.git.agordeev@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Feb 04, 2014 at 12:17:07PM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() and pci_enable_msix_range() > interfaces. Hi Vikas, Any feedback on this? Thanks!
On 04/02/14 3:17 AM, "Alexander Gordeev" <agordeev@redhat.com> wrote: >As result of deprecation of MSI-X/MSI enablement functions >pci_enable_msix() and pci_enable_msi_block() all drivers >using these two interfaces need to be updated to use the >new pci_enable_msi_range() and pci_enable_msix_range() >interfaces. > >Signed-off-by: Alexander Gordeev <agordeev@redhat.com> >Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com> >Cc: iscsi-driver@qlogic.com >Cc: linux-scsi@vger.kernel.org >Cc: linux-pci@vger.kernel.org >--- > drivers/scsi/qla4xxx/ql4_nx.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c >index d001202..7f5412d 100644 >--- a/drivers/scsi/qla4xxx/ql4_nx.c >+++ b/drivers/scsi/qla4xxx/ql4_nx.c >@@ -3805,8 +3805,9 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) > for (i = 0; i < QLA_MSIX_ENTRIES; i++) > entries[i].entry = qla4_8xxx_msix_entries[i].entry; > >- ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); >- if (ret) { >+ ret = pci_enable_msix_range(ha->pdev, entries, >+ ARRAY_SIZE(entries), ARRAY_SIZE(entries)); >+ if (ret < 0) { > ql4_printk(KERN_WARNING, ha, > "MSI-X: Failed to enable support -- %d/%d\n", > QLA_MSIX_ENTRIES, ret); Looks good to me. Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index d001202..7f5412d 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -3805,8 +3805,9 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha) for (i = 0; i < QLA_MSIX_ENTRIES; i++) entries[i].entry = qla4_8xxx_msix_entries[i].entry; - ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries)); - if (ret) { + ret = pci_enable_msix_range(ha->pdev, entries, + ARRAY_SIZE(entries), ARRAY_SIZE(entries)); + if (ret < 0) { ql4_printk(KERN_WARNING, ha, "MSI-X: Failed to enable support -- %d/%d\n", QLA_MSIX_ENTRIES, ret);
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Cc: iscsi-driver@qlogic.com Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/qla4xxx/ql4_nx.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)