From patchwork Wed Aug 19 14:34:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 31649 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id EB8C2B70CF for ; Thu, 20 Aug 2009 00:40:41 +1000 (EST) Received: from localhost ([127.0.0.1]:47581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdmL7-0007hn-Tz for incoming@patchwork.ozlabs.org; Wed, 19 Aug 2009 10:40:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdmHN-0006MR-AD for qemu-devel@nongnu.org; Wed, 19 Aug 2009 10:36:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdmHJ-0006K8-QX for qemu-devel@nongnu.org; Wed, 19 Aug 2009 10:36:45 -0400 Received: from [199.232.76.173] (port=46913 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdmHJ-0006K5-Jo for qemu-devel@nongnu.org; Wed, 19 Aug 2009 10:36:41 -0400 Received: from [66.187.237.31] (port=37248 helo=mx2.redhat.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdmHI-0003Lo-RJ for qemu-devel@nongnu.org; Wed, 19 Aug 2009 10:36:41 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7JEaWsI020118 for ; Wed, 19 Aug 2009 10:36:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n7JEaUF7004538; Wed, 19 Aug 2009 10:36:30 -0400 Received: from localhost.localdomain (vpn1-4-115.ams2.redhat.com [10.36.4.115]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7JEaPMv005041; Wed, 19 Aug 2009 10:36:29 -0400 From: Juan Quintela To: qemu-devel@nongnu.org Date: Wed, 19 Aug 2009 16:34:13 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [PATCH 2/3] Port apic to new VMState design X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Juan Quintela --- hw/apic.c | 67 ++++++++++++++++++++++++++++++------------------------------- 1 files changed, 33 insertions(+), 34 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index 1927811..141c5f2 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -864,39 +864,8 @@ static void apic_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val) } } -static void apic_save(QEMUFile *f, void *opaque) -{ - APICState *s = opaque; - int i; - - qemu_put_be32s(f, &s->apicbase); - qemu_put_8s(f, &s->id); - qemu_put_8s(f, &s->arb_id); - qemu_put_8s(f, &s->tpr); - qemu_put_be32s(f, &s->spurious_vec); - qemu_put_8s(f, &s->log_dest); - qemu_put_8s(f, &s->dest_mode); - for (i = 0; i < 8; i++) { - qemu_put_be32s(f, &s->isr[i]); - qemu_put_be32s(f, &s->tmr[i]); - qemu_put_be32s(f, &s->irr[i]); - } - for (i = 0; i < APIC_LVT_NB; i++) { - qemu_put_be32s(f, &s->lvt[i]); - } - qemu_put_be32s(f, &s->esr); - qemu_put_be32s(f, &s->icr[0]); - qemu_put_be32s(f, &s->icr[1]); - qemu_put_be32s(f, &s->divide_conf); - qemu_put_be32(f, s->count_shift); - qemu_put_be32s(f, &s->initial_count); - qemu_put_be64(f, s->initial_count_load_time); - qemu_put_be64(f, s->next_time); - - qemu_put_timer(f, s->timer); -} - -static int apic_load(QEMUFile *f, void *opaque, int version_id) +/* This function is only used for old state version 1 and 2 */ +static int apic_load_old(QEMUFile *f, void *opaque, int version_id) { APICState *s = opaque; int i; @@ -934,6 +903,36 @@ static int apic_load(QEMUFile *f, void *opaque, int version_id) return 0; } +static const VMStateDescription vmstate_apic = { + .name = "apic", + .version_id = 3, + .minimum_version_id = 3, + .minimum_version_id_old = 1, + .load_state_old = apic_load_old, + .fields = (VMStateField []) { + VMSTATE_UINT32(apicbase, APICState), + VMSTATE_UINT8(id, APICState), + VMSTATE_UINT8(arb_id, APICState), + VMSTATE_UINT8(tpr, APICState), + VMSTATE_UINT32(spurious_vec, APICState), + VMSTATE_UINT8(log_dest, APICState), + VMSTATE_UINT8(dest_mode, APICState), + VMSTATE_UINT32_ARRAY(isr, APICState, 8), + VMSTATE_UINT32_ARRAY(tmr, APICState, 8), + VMSTATE_UINT32_ARRAY(irr, APICState, 8), + VMSTATE_UINT32_ARRAY(lvt, APICState, APIC_LVT_NB), + VMSTATE_UINT32(esr, APICState), + VMSTATE_UINT32_ARRAY(icr, APICState, 2), + VMSTATE_UINT32(divide_conf, APICState), + VMSTATE_INT32(count_shift, APICState), + VMSTATE_UINT32(initial_count, APICState), + VMSTATE_INT64(initial_count_load_time, APICState), + VMSTATE_INT64(next_time, APICState), + VMSTATE_TIMER(timer, APICState), + VMSTATE_END_OF_LIST() + } +}; + static void apic_reset(void *opaque) { APICState *s = opaque; @@ -996,7 +995,7 @@ int apic_init(CPUState *env) } s->timer = qemu_new_timer(vm_clock, apic_timer, s); - register_savevm("apic", s->idx, 2, apic_save, apic_load, s); + vmstate_register(s->idx, &vmstate_apic, s); qemu_register_reset(apic_reset, s); local_apics[s->idx] = s;