Patchwork [2/6] We want to autostart on incoming conections Once there, indent surrounded code in qemu style

login
register
mail settings
Submitter Juan Quintela
Date Aug. 19, 2009, 2:07 a.m.
Message ID <991e83f9676e77bb3a396d1544756b89cba7d373.1250646771.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/31619/
State Superseded
Headers show

Comments

Juan Quintela - Aug. 19, 2009, 2:07 a.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 vl.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
Paolo Bonzini - Aug. 19, 2009, 6:56 a.m.
On 08/19/2009 04:07 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela<quintela@redhat.com>
> ---
>   vl.c |    6 ++----
>   1 files changed, 2 insertions(+), 4 deletions(-)

This is effectively reverting 2bb8c10c (more or less) and is already in 
Anthony's queue.

Paolo
Juan Quintela - Aug. 19, 2009, 9:18 a.m.
Reply-to: quintela@redhat.com
Paolo Bonzini <bonzini@gnu.org> wrote:
> On 08/19/2009 04:07 AM, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>> ---
>>   vl.c |    6 ++----
>>   1 files changed, 2 insertions(+), 4 deletions(-)
>
> This is effectively reverting 2bb8c10c (more or less) and is already
> in Anthony's queue.

But the series make everything work as expected and consistently, just
now it is a mess :(

Later, Juan.
Paolo Bonzini - Aug. 19, 2009, 10:54 a.m.
On 08/19/2009 11:18 AM, Juan Quintela wrote:
> Reply-to: quintela@redhat.com
> Paolo Bonzini<bonzini@gnu.org>  wrote:
>> On 08/19/2009 04:07 AM, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>> ---
>>>    vl.c |    6 ++----
>>>    1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> This is effectively reverting 2bb8c10c (more or less) and is already
>> in Anthony's queue.
>
> But the series make everything work as expected and consistently, just
> now it is a mess :(

I was not saying it is wrong, just that it is unnecessary when applied 
on aliguori-queue.git. :-)

Paolo

Patch

diff --git a/vl.c b/vl.c
index 66246af..e86bdce 100644
--- a/vl.c
+++ b/vl.c
@@ -6040,12 +6040,10 @@  int main(int argc, char **argv, char **envp)
         do_loadvm(cur_mon, loadvm);

     if (incoming) {
-        autostart = 0;
         qemu_start_incoming_migration(incoming);
-    }
-
-    else if (autostart)
+    } else if (autostart) {
         vm_start();
+    }

 #ifndef _WIN32
     if (daemonize) {