Message ID | 1391425657-30915-2-git-send-email-francois.perrad@gadz.org |
---|---|
State | Superseded, archived |
Headers | show |
François, All, A few nit-picks below... On 2014-02-03 12:07 +0100, Francois Perrad spake thusly: > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> [--SNIP--] > diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in > new file mode 100644 > index 0000000..3d2af35 > --- /dev/null > +++ b/package/ljlinenoise/Config.in > @@ -0,0 +1,15 @@ > +config BR2_PACKAGE_LJLINENOISE > + bool "ljlinenoise" > + select BR2_PACKAGE_LJSYSCALL > + # ljsyscall is specifically for LuaJIT, not Lua. > + depends on BR2_PACKAGE_LUAJIT > + # ljsyscall is only available for some target architectures > + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb No need for the comment, it is obvious from the dependency itself that ljlinenoise only works on these architectures. However, it's maybe worth a comment in the commit log. > + help > + ljlinenoise is a pure LuaJIT port of linenoise, > + a small alternative to readline and libedit. > + > + http://fperrad.github.io/ljlinenoise/ > + > +comment "ljlinenoise needs LuaJIT" > + depends on !BR2_PACKAGE_LUAJIT && (BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb) > diff --git a/package/ljlinenoise/ljlinenoise.mk b/package/ljlinenoise/ljlinenoise.mk > new file mode 100644 > index 0000000..69f6130 > --- /dev/null > +++ b/package/ljlinenoise/ljlinenoise.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# ljlinenoise > +# > +################################################################################ > + > +LJLINENOISE_VERSION_UPSTREAM = 0.1.1 > +LJLINENOISE_VERSION = $(LJLINENOISE_VERSION_UPSTREAM)-1 > +LJLINENOISE_SUBDIR = ljlinenoise-$(LJLINENOISE_VERSION_UPSTREAM) ^^ Very small nit-pick: only one space in front of the '=' sing. Regards, Yann E. MORIN.
Dear Yann E. MORIN, On Mon, 3 Feb 2014 21:26:31 +0100, Yann E. MORIN wrote: > > diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in > > new file mode 100644 > > index 0000000..3d2af35 > > --- /dev/null > > +++ b/package/ljlinenoise/Config.in > > @@ -0,0 +1,15 @@ > > +config BR2_PACKAGE_LJLINENOISE > > + bool "ljlinenoise" > > + select BR2_PACKAGE_LJSYSCALL > > + # ljsyscall is specifically for LuaJIT, not Lua. > > + depends on BR2_PACKAGE_LUAJIT > > + # ljsyscall is only available for some target architectures > > + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb > > No need for the comment, it is obvious from the dependency itself that > ljlinenoise only works on these architectures. Hum, really? These dependencies are inherited from ljsyscall, which is selected by this package. In such a situation, we normally do something like: select BR2_PACKAGE_LIBGLIB2 depends on BR2_USE_WCHAR # libglib2 so having the same comment mentioned here makes sense, IMO, as it helps understanding where the architecture dependency is coming from. Thomas
Thomas, François, All, On 2014-02-03 22:56 +0100, Thomas Petazzoni spake thusly: > On Mon, 3 Feb 2014 21:26:31 +0100, Yann E. MORIN wrote: > > > > diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in > > > new file mode 100644 > > > index 0000000..3d2af35 > > > --- /dev/null > > > +++ b/package/ljlinenoise/Config.in > > > @@ -0,0 +1,15 @@ > > > +config BR2_PACKAGE_LJLINENOISE > > > + bool "ljlinenoise" > > > + select BR2_PACKAGE_LJSYSCALL > > > + # ljsyscall is specifically for LuaJIT, not Lua. > > > + depends on BR2_PACKAGE_LUAJIT > > > + # ljsyscall is only available for some target architectures > > > + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb > > > > No need for the comment, it is obvious from the dependency itself that > > ljlinenoise only works on these architectures. > > Hum, really? These dependencies are inherited from ljsyscall, which is > selected by this package. In such a situation, we normally do something > like: > > select BR2_PACKAGE_LIBGLIB2 > depends on BR2_USE_WCHAR # libglib2 > > so having the same comment mentioned here makes sense, IMO, as it helps > understanding where the architecture dependency is coming from. OK, my bad, I misread 'ljlinenoise' when 'ljsyscall' was properly written. Forget what I said about this. Sorry for the noise. As Thomas said, just post-fix the depends with '# ljsyscall'. Regards, Yann E. MORIN.
diff --git a/package/Config.in b/package/Config.in index 93d23cb..c757c68 100644 --- a/package/Config.in +++ b/package/Config.in @@ -370,6 +370,7 @@ source "package/cgilua/Config.in" source "package/copas/Config.in" source "package/coxpcall/Config.in" source "package/lbase64/Config.in" +source "package/ljlinenoise/Config.in" source "package/ljsyscall/Config.in" source "package/lua-cjson/Config.in" source "package/lua-ev/Config.in" diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in new file mode 100644 index 0000000..3d2af35 --- /dev/null +++ b/package/ljlinenoise/Config.in @@ -0,0 +1,15 @@ +config BR2_PACKAGE_LJLINENOISE + bool "ljlinenoise" + select BR2_PACKAGE_LJSYSCALL + # ljsyscall is specifically for LuaJIT, not Lua. + depends on BR2_PACKAGE_LUAJIT + # ljsyscall is only available for some target architectures + depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb + help + ljlinenoise is a pure LuaJIT port of linenoise, + a small alternative to readline and libedit. + + http://fperrad.github.io/ljlinenoise/ + +comment "ljlinenoise needs LuaJIT" + depends on !BR2_PACKAGE_LUAJIT && (BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb) diff --git a/package/ljlinenoise/ljlinenoise.mk b/package/ljlinenoise/ljlinenoise.mk new file mode 100644 index 0000000..69f6130 --- /dev/null +++ b/package/ljlinenoise/ljlinenoise.mk @@ -0,0 +1,13 @@ +################################################################################ +# +# ljlinenoise +# +################################################################################ + +LJLINENOISE_VERSION_UPSTREAM = 0.1.1 +LJLINENOISE_VERSION = $(LJLINENOISE_VERSION_UPSTREAM)-1 +LJLINENOISE_SUBDIR = ljlinenoise-$(LJLINENOISE_VERSION_UPSTREAM) +LJLINENOISE_LICENSE = MIT +LJLINENOISE_LICENSE_FILES = $(LJLINENOISE_SUBDIR)/COPYRIGHT + +$(eval $(luarocks-package))
Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/Config.in | 1 + package/ljlinenoise/Config.in | 15 +++++++++++++++ package/ljlinenoise/ljlinenoise.mk | 13 +++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 package/ljlinenoise/Config.in create mode 100644 package/ljlinenoise/ljlinenoise.mk