diff mbox

[-next] net: fix ks8851 build errors

Message ID 20090818152705.64557a0b.randy.dunlap@oracle.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Randy Dunlap Aug. 18, 2009, 10:27 p.m. UTC 
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix build errors due to missing Kconfig selects:

ks8851.c:(.text+0x7d2ee): undefined reference to `crc32_le'
ks8851.c:(.text+0x7d2f5): undefined reference to `bitrev32'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)




---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Aug. 19, 2009, 3:12 a.m. UTC | #1 
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 18 Aug 2009 15:27:05 -0700

> --- linux-next-20090818.orig/drivers/net/Kconfig
> +++ linux-next-20090818/drivers/net/Kconfig
> @@ -1733,6 +1733,8 @@ config KS8851
>         tristate "Micrel KS8851 SPI"
>         depends on SPI
>         select MII
> +	select CRC32
> +	select BITREVERSE
>         help
>           SPI driver for Micrel KS8851 SPI attached network chip.
>  

CRC32 alone is sufficient, because it, in turn, selects BITREVERSE

When you resubmit with this simplification, I'll apply the
patch to net-2.6 since the problem exists in Linus's tree
too, not just -next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- linux-next-20090818.orig/drivers/net/Kconfig
+++ linux-next-20090818/drivers/net/Kconfig
@@ -1733,6 +1733,8 @@  config KS8851
        tristate "Micrel KS8851 SPI"
        depends on SPI
        select MII
+	select CRC32
+	select BITREVERSE
        help
          SPI driver for Micrel KS8851 SPI attached network chip.