| Message ID | 1391371626-13551-1-git-send-email-Larry.Finger@lwfinger.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 02/02/2014 12:07 PM, Larry Finger wrote: > There is a typo in the device list that interchanges the vendor and > product codes for one of the entries. You also changed 0x7b8 to 0x7bb. Did you mean to do that? > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > index 0a341d6..e9e3c76 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = { > {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */ > /*=== Customer ID ===*/ > /****** 8188EUS ********/ > - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */ > + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */ > {USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */ > {} /* Terminating entry */ > }; >
On 02/02/2014 03:04 PM, Randy Dunlap wrote: > On 02/02/2014 12:07 PM, Larry Finger wrote: >> There is a typo in the device list that interchanges the vendor and >> product codes for one of the entries. > > You also changed 0x7b8 to 0x7bb. > Did you mean to do that? No, I did not. Thanks for catching that typo. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: > There is a typo in the device list that interchanges the vendor and > product codes for one of the entries. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > index 0a341d6..e9e3c76 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = { > {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */ > /*=== Customer ID ===*/ > /****** 8188EUS ********/ > - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */ > + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */ Becides the b8 -> bb issue, are you sure this is correct? I've seen lots of USB devices that got this backwards (vendor id in the product id place), so it wouldn't be the first time it's happened. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/02/2014 03:26 PM, Greg KH wrote: > On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: >> There is a typo in the device list that interchanges the vendor and >> product codes for one of the entries. >> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> --- >> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c >> index 0a341d6..e9e3c76 100644 >> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c >> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c >> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = { >> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */ >> /*=== Customer ID ===*/ >> /****** 8188EUS ********/ >> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */ >> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */ > > Becides the b8 -> bb issue, are you sure this is correct? I've seen > lots of USB devices that got this backwards (vendor id in the product id > place), so it wouldn't be the first time it's happened. The listing at http://www.linux-usb.org/usb.ids shows that the vendor code for AboCom Systems Inc is 0x07b8. Although it does not show a device id of 0x8179, I'm pretty sure that this listing has reversed the two entries. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote: > There is a typo in the device list that interchanges the vendor and > product codes for one of the entries. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > index 0a341d6..e9e3c76 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = { > {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */ > /*=== Customer ID ===*/ > /****** 8188EUS ********/ > - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */ > + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */ ^^^^^^ Should this be 0x07b8? regards, dan carpenter > {USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */ > {} /* Terminating entry */ > }; > -- > 1.8.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index 0a341d6..e9e3c76 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = { {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */ /*=== Customer ID ===*/ /****** 8188EUS ********/ - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */ + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */ {USB_DEVICE(0x2001, 0x330F)}, /* DLink DWA-125 REV D1 */ {} /* Terminating entry */ };
There is a typo in the device list that interchanges the vendor and product codes for one of the entries. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)