| Message ID | 1391205924-28586-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
01.02.2014 02:05, Stefan Weil wrote: > Instead of packing BiosLinkerLoaderEntry, an unused global variable called > QEMU_PACKED was created (detected by smatch static code analysis). > > Including qemu-common.h gets the right definition and also includes some > standard include files which now can be removed here. A good one. Thanks, applied to the trivial patches queue. /mjt
diff --git a/hw/i386/bios-linker-loader.c b/hw/i386/bios-linker-loader.c index fd23611..aa56184 100644 --- a/hw/i386/bios-linker-loader.c +++ b/hw/i386/bios-linker-loader.c @@ -18,11 +18,10 @@ * with this program; if not, see <http://www.gnu.org/licenses/>. */ +#include "qemu-common.h" #include "bios-linker-loader.h" #include "hw/nvram/fw_cfg.h" -#include <string.h> -#include <assert.h> #include "qemu/bswap.h" #define BIOS_LINKER_LOADER_FILESZ FW_CFG_MAX_FILE_PATH
Instead of packing BiosLinkerLoaderEntry, an unused global variable called QEMU_PACKED was created (detected by smatch static code analysis). Including qemu-common.h gets the right definition and also includes some standard include files which now can be removed here. Cc: qemu-stable@nongnu.org Signed-off-by: Stefan Weil <sw@weilnetz.de> --- hw/i386/bios-linker-loader.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)